Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GCS+gRPC): support timeouts for all requests #7299

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 10, 2021

This change makes the gRPC plugin support timeouts for all requests,
just like we do in REST. The REST timeouts are more clever, based on
progress vs. completion, I am planning to create a separate bug to
improve GCS+gRPC and support progress-based timeouts too.

Fixes #4216


This change is Reviewable

This change makes the gRPC plugin support timeouts for all requests,
just like we do in REST.  The REST timeouts are more clever, based on
progress vs. completion, I am planning to create a separate bug to
improve GCS+gRPC and support progress-based timeouts too.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 10, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: fc676379fe9e9a953c7a1d602361d8110a23eed4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #7299 (fc67637) into main (0ab93d4) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7299      +/-   ##
==========================================
- Coverage   93.47%   93.47%   -0.01%     
==========================================
  Files        1344     1344              
  Lines      116330   116342      +12     
==========================================
+ Hits       108744   108753       +9     
- Misses       7586     7589       +3     
Impacted Files Coverage Δ
google/cloud/storage/internal/grpc_client.h 100.00% <ø> (ø)
.../storage/internal/grpc_resumable_upload_session.cc 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client.cc 92.64% <100.00%> (+0.15%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab93d4...fc67637. Read the comment docs.

@coryan coryan marked this pull request as ready for review September 10, 2021 16:20
@coryan coryan requested a review from a team as a code owner September 10, 2021 16:20
@coryan coryan merged commit 7ee1d91 into googleapis:main Sep 10, 2021
@coryan coryan deleted the feat-gcs-grpc-support-timeouts-for-all-requests branch September 10, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GCS+gRPC plugin should timeout uploads with no progress
3 participants