Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): build with MSVC+x86 #7323

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Sep 16, 2021

This change is Reviewable

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Sep 16, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d0b45ccfb07618d5c4cdde0c6e1b3c189a115bb9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #7323 (aa90307) into main (5b6c09b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7323   +/-   ##
=======================================
  Coverage   93.65%   93.66%           
=======================================
  Files        1348     1348           
  Lines      116747   116747           
=======================================
+ Hits       109344   109350    +6     
+ Misses       7403     7397    -6     
Impacted Files Coverage Δ
google/cloud/storage/version.h 100.00% <ø> (ø)
google/cloud/pubsub/publisher_connection_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/samples/samples.cc 91.97% <0.00%> (-0.08%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.91% <0.00%> (+0.69%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.25% <0.00%> (+0.74%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+1.17%) ⬆️
google/cloud/grpc_error_delegate.cc 100.00% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b6c09b...aa90307. Read the comment docs.

@coryan coryan marked this pull request as ready for review September 16, 2021 16:22
@coryan coryan requested a review from a team as a code owner September 16, 2021 16:22
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: aa903077b5de6dabc97732b92c51921507c6f038

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit d13c07f into googleapis:main Sep 16, 2021
@coryan coryan deleted the fix-storage-deprecated-warnings-and-msvc branch September 16, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants