feat(generator): add "generator" to API client header "gccl" semver #7383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Strip the leading "v" from the value of the "gccl" component in the `X-Goog-Api-Client` header so that what remains is a valid semantic version string (see https://semver.org/). 2. Add a "generator" build identifier to the "gccl" semvar for requests sent from generated clients. The upshot is that the library-version component of the client header will be "gccl/<major>.<minor>.<patch>+<git-hash>.generator", allowing us to identify requests from generated clients.
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7383 +/- ##
=======================================
Coverage 93.64% 93.65%
=======================================
Files 1351 1351
Lines 117315 117334 +19
=======================================
+ Hits 109865 109885 +20
+ Misses 7450 7449 -1
Continue to review full report at Codecov.
|
coryan
changed the title
coryan
approved these changes
Sep 30, 2021
devbww
added a commit
to devbww/google-cloud-cpp
that referenced
this pull request
Oct 15, 2021
Resume sending the leading "v" in the value of the "gccl" component of the `X-Goog-Api-Client` header (see googleapis#7383). The Cloud Spanner frontend's route lookup service uses the version string in a semver comparison to determine how the request should be routed, and it currently expects to see a literal "v". (For the record, the minimal version supported by the route lookup service is "v1.17.1".) Changing the route lookup service to not care about the leading "v" is non-trivial (it uses a single-value map, indexed by language, to store the minimum supported version, and the value comes from a flag), and even then the fix will take some time to roll out, so, in the meantime, we revert to sending the "v". Eventually eliminating the "v" is still a goal because it makes the header conform to the specification, and it also makes C++ behave like the other languages.
devbww
added a commit
that referenced
this pull request
Oct 15, 2021
) Resume sending the leading "v" in the value of the "gccl" component of the `X-Goog-Api-Client` header (see #7383). The Cloud Spanner frontend's route lookup service uses the version string in a semver comparison to determine how the request should be routed, and it currently expects to see a literal "v". (For the record, the minimal version supported by the route lookup service is "v1.17.1".) Changing the route lookup service to not care about the leading "v" is non-trivial (it uses a single-value map, indexed by language, to store the minimum supported version, and the value comes from a flag), and even then the fix will take some time to roll out, so, in the meantime, we revert to sending the "v". Eventually eliminating the "v" is still a goal because it makes the header conform to the specification, and it also makes C++ behave like the other languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip the leading "v" from the value of the "gccl" component in the
X-Goog-Api-Clientheader so that what remains is a valid semanticversion string (see https://semver.org/).
Add a "generator" build identifier to the "gccl" semver for requests
sent from generated clients.
The upshot is that the library-version component of the client header
will be
gccl/<major>.<minor>.<patch>+<git-hash>.generator, allowingus to identify requests from generated clients.
This change is