Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): implement GUAC for TopicAdmin #7428

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 8, 2021

Part of the work for #6463


This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 8, 2021
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 8, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b65db0a59840563fcc3aedc922d3953ebe952ca6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #7428 (b65db0a) into main (37727e1) will increase coverage by 0.00%.
The diff coverage is 99.15%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #7428    +/-   ##
========================================
  Coverage   93.60%   93.61%            
========================================
  Files        1353     1356     +3     
  Lines      117541   117756   +215     
========================================
+ Hits       110024   110237   +213     
- Misses       7517     7519     +2     
Impacted Files Coverage Δ
google/cloud/pubsub/internal/publisher_stub.h 100.00% <ø> (ø)
google/cloud/pubsub/topic_admin_connection.cc 85.39% <92.85%> (+0.87%) ⬆️
.../integration_tests/topic_admin_integration_test.cc 99.01% <100.00%> (+1.24%) ⬆️
google/cloud/pubsub/internal/publisher_auth.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/internal/publisher_auth.h 100.00% <100.00%> (ø)
...oogle/cloud/pubsub/internal/publisher_auth_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/internal/publisher_stub.cc 96.72% <100.00%> (+0.11%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 97.18% <0.00%> (-0.71%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 85.52% <0.00%> (-0.66%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37727e1...b65db0a. Read the comment docs.

@coryan coryan marked this pull request as ready for review October 8, 2021 15:08
@coryan coryan requested a review from a team as a code owner October 8, 2021 15:08
@coryan coryan merged commit 4c52d0d into googleapis:main Oct 8, 2021
@coryan coryan deleted the feat-pubsub-guac-for-topic-admin branch October 8, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants