Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): implement GUAC for Publisher #7440

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 11, 2021

Part of the work for #6463


This change is Reviewable

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 11, 2021
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 105960b2c58f82e505b931b93266091355b46e7b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #7440 (105960b) into main (e38b7c1) will decrease coverage by 0.00%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7440      +/-   ##
==========================================
- Coverage   93.64%   93.64%   -0.01%     
==========================================
  Files        1362     1362              
  Lines      118232   118253      +21     
==========================================
+ Hits       110719   110736      +17     
- Misses       7513     7517       +4     
Impacted Files Coverage Δ
google/cloud/pubsub/publisher_connection.cc 79.26% <93.87%> (+2.21%) ⬆️
google/cloud/pubsub/internal/create_channel.cc 90.90% <100.00%> (-9.10%) ⬇️
google/cloud/pubsub/publisher_connection_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/internal/publisher_stub.cc 93.44% <0.00%> (-3.28%) ⬇️
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
google/cloud/grpc_error_delegate.cc 100.00% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38b7c1...105960b. Read the comment docs.

@coryan coryan marked this pull request as ready for review October 11, 2021 21:07
@coryan coryan requested a review from a team as a code owner October 11, 2021 21:07
@coryan coryan merged commit 677e5f1 into googleapis:main Oct 11, 2021
@coryan coryan deleted the feat-pubsub-implement-guac-for-publisher branch October 11, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants