refactor(hand-written-products): to use GOOGLE_CLOUD_CPP_NS for inline namespace #7441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7441 +/- ##
==========================================
- Coverage 93.64% 93.63% -0.01%
==========================================
Files 1362 1362
Lines 118253 118253
==========================================
- Hits 110736 110732 -4
- Misses 7517 7521 +4
Continue to review full report at Codecov.
|
coryan
approved these changes
Oct 11, 2021
devjgm
force-pushed
the
rename-product-ns
branch
from
c5b4359 to
fa1d5ac
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #5976
For {spanner,bigtable,storage,pubsub}, they all now directly use
GOOGLE_CLOUD_CPP_NSas the name of their inline namespace. This resolves to the exact same thing as it did before, so this is not a breaking change.The old namespace names of
GOOGLE_CLOUD_CPP_PUBSUB_NS,BIGTABLE_CLIENT_NS,SPANNER_CLIENT_NS, andSTORAGE_CLIENT_NSare now commented as deprecated, but they are still defined to be equivalent toGOOGLE_CLOUD_CPP_NS, so this change should not break any customers.ATTENTION REVIEWERS: This PR is mostly search-n-replace changes. The only files with hand edits are:
cmake/GoogleCloudCppCommon.cmakegoogle/cloud/*/version.h, where the addition is just a commentThis change is