Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): GUAC for async read-write streams #7442

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 11, 2021

This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 00fc96c41729be265e65e4b00884684ac2982aa0

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #7442 (4eacd41) into main (6137b15) will decrease coverage by 0.00%.
The diff coverage is 91.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7442      +/-   ##
==========================================
- Coverage   93.64%   93.64%   -0.01%     
==========================================
  Files        1362     1364       +2     
  Lines      118253   118330      +77     
==========================================
+ Hits       110735   110805      +70     
- Misses       7518     7525       +7     
Impacted Files Coverage Δ
google/cloud/pubsub/internal/subscriber_auth.h 100.00% <ø> (ø)
google/cloud/pubsub/internal/subscriber_logging.h 100.00% <ø> (ø)
...oogle/cloud/pubsub/internal/subscriber_metadata.cc 100.00% <ø> (ø)
...le/cloud/pubsub/internal/subscriber_round_robin.cc 100.00% <ø> (ø)
...gle/cloud/pubsub/internal/subscriber_round_robin.h 100.00% <ø> (ø)
google/cloud/pubsub/internal/subscriber_stub.h 100.00% <ø> (ø)
...ogle/cloud/internal/async_read_write_stream_auth.h 82.85% <82.85%> (ø)
...loud/internal/async_read_write_stream_auth_test.cc 97.14% <97.14%> (ø)
...ternal/streaming_subscription_batch_source_test.cc 99.23% <100.00%> (ø)
google/cloud/pubsub/internal/subscriber_auth.cc 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6137b15...4eacd41. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 4eacd41a42db80207bee36e60a2b0df1a4dea86d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review October 12, 2021 12:44
@coryan coryan requested a review from a team as a code owner October 12, 2021 12:44
@coryan coryan merged commit 8b9498f into googleapis:main Oct 12, 2021
@coryan coryan deleted the feat-pubsub-implement-guac-for-subscriber branch October 12, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants