cleanup(pubsub): consistent code order in *connection #7451

coryan · 2021-10-13T14:08:49Z

This is a trivial change, you could say cosmetic, to make all the
pubsub/*_connection.cc files have the same structure. Makes it easier
to make changes across all of them.

Part of the work for #6463

This change is

This is a trivial change, you could say cosmetic, to make all the `pubsub/*_connection.cc` files have the same structure. Makes it easier to make changes across all of them.

google-cloud-cpp-bot · 2021-10-13T14:10:57Z

Google Cloud Build Logs
For commit: 8e3d444b5df34ff68c869956a0d9ba8efb4cf814

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

dbolduc

Good idea 👍

codecov · 2021-10-13T14:30:37Z

Codecov Report

Merging #7451 (8e3d444) into main (a9b2e46) will decrease coverage by 0.00%.
The diff coverage is 84.90%.

@@            Coverage Diff             @@
##             main    #7451      +/-   ##
==========================================
- Coverage   93.64%   93.64%   -0.01%     
==========================================
  Files        1364     1364              
  Lines      118361   118359       -2     
==========================================
- Hits       110845   110842       -3     
- Misses       7516     7517       +1

Impacted Files	Coverage Δ
...ogle/cloud/pubsub/subscription_admin_connection.cc	`83.58% <74.19%> (ø)`
google/cloud/pubsub/schema_admin_connection.cc	`91.83% <100.00%> (-0.09%)`	⬇️
google/cloud/pubsub/topic_admin_connection.cc	`86.04% <100.00%> (-0.09%)`	⬇️
google/cloud/bigtable/internal/common_client.h	`94.02% <0.00%> (-5.98%)`	⬇️
...cloud/pubsub/internal/subscription_session_test.cc	`97.75% <0.00%> (-0.25%)`	⬇️
google/cloud/pubsub/samples/samples.cc	`92.10% <0.00%> (+0.07%)`	⬆️
...le/cloud/storage/internal/curl_download_request.cc	`89.62% <0.00%> (+0.37%)`	⬆️
google/cloud/pubsub/subscriber_connection_test.cc	`97.88% <0.00%> (+0.70%)`	⬆️
google/cloud/bigtable/internal/common_client.cc	`97.14% <0.00%> (+1.42%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b2e46...8e3d444. Read the comment docs.

cleanup(pubsub): consistent code order in *connection

8e3d444

This is a trivial change, you could say cosmetic, to make all the `pubsub/*_connection.cc` files have the same structure. Makes it easier to make changes across all of them.

product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Oct 13, 2021

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021

dbolduc approved these changes Oct 13, 2021

View reviewed changes

coryan marked this pull request as ready for review October 13, 2021 14:18

coryan requested a review from a team as a code owner October 13, 2021 14:18

coryan merged commit a238002 into googleapis:main Oct 13, 2021

coryan deleted the cleanup-pubsub-reorder-code-in-connection-cc branch October 13, 2021 14:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cleanup(pubsub): consistent code order in *connection #7451

cleanup(pubsub): consistent code order in *connection #7451

coryan commented Oct 13, 2021 •

edited

Loading

google-cloud-cpp-bot commented Oct 13, 2021

dbolduc left a comment

codecov bot commented Oct 13, 2021 •

edited

Loading

cleanup(pubsub): consistent code order in *connection #7451

cleanup(pubsub): consistent code order in *connection #7451

Conversation

coryan commented Oct 13, 2021 • edited Loading

google-cloud-cpp-bot commented Oct 13, 2021

dbolduc left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 13, 2021 • edited Loading

Codecov Report

coryan commented Oct 13, 2021 •

edited

Loading

codecov bot commented Oct 13, 2021 •

edited

Loading