test(spanner): relax an expectation about JSON keys in emulator #7517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Spanner emulator is gaining support for JSON values, which means we need to start changing some test expectations. We were somewhat particular about what errors to expect so that we could discern when the emulator's behavior started to change. In this test case, where we use a JSON column as a primary key (which is always an error), we were expecting a parse error on the word "JSON", but, for now, we're happy with any kind of error. We might still get the "INVALID_ARGUMENT" parsing error, or we could get the true "INVALID_ARGUMENT" primary-key error, or we might even get "UNIMPLEMENTED" if the emulator has JSON support dynamically disabled.
google-cla
bot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7517 +/- ##
=======================================
Coverage 93.66% 93.66%
=======================================
Files 1361 1361
Lines 118103 118101 -2
=======================================
- Hits 110624 110623 -1
+ Misses 7479 7478 -1
Continue to review full report at Codecov.
|
coryan
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Spanner emulator is gaining support for JSON values, which means
we need to start changing some test expectations. We were somewhat
particular about what errors to expect so that we could discern when
the emulator's behavior started to change.
In this test case, where we use a JSON column as a primary key (which
is always an error), we were expecting a parse error on the word
"JSON", but, for now, we're happy with any kind of error. We might
still get the "INVALID_ARGUMENT" parsing error, or we could get the
true "INVALID_ARGUMENT" primary-key error, or we might even get
"UNIMPLEMENTED" if the emulator has JSON support dynamically disabled.
This change is