Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): respect ContentType in Client::UploadFile #7521

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Oct 26, 2021

Fixes #7520


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 26, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 23d855880ba74d041193295d1f87e03a7686c1ab

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #7521 (23d8558) into main (38959b4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7521   +/-   ##
=======================================
  Coverage   93.66%   93.67%           
=======================================
  Files        1361     1361           
  Lines      118101   118146   +45     
=======================================
+ Hits       110622   110668   +46     
+ Misses       7479     7478    -1     
Impacted Files Coverage Δ
google/cloud/storage/internal/curl_client.cc 98.28% <100.00%> (+0.04%) ⬆️
...loud/storage/tests/object_file_integration_test.cc 100.00% <100.00%> (ø)
...bigtable/examples/bigtable_hello_instance_admin.cc 81.31% <0.00%> (-2.20%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.00% <0.00%> (-0.60%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.25% <0.00%> (+0.23%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38959b4...23d8558. Read the comment docs.

@coryan coryan marked this pull request as ready for review October 26, 2021 22:14
@coryan coryan requested a review from a team as a code owner October 26, 2021 22:14
@coryan coryan merged commit 9c57f59 into googleapis:main Oct 27, 2021
@coryan coryan deleted the fix-storage-upload-file-and-content-type branch October 27, 2021 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client::UploadFile() fails to upload image file
3 participants