Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GCS+gRPC): correct format Object ids #7559

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 4, 2021

I was confused about the JSON format for Object ids the wrong synthetic values.


This change is Reviewable

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: cc47484bb44d06800420eeaee3671c91f0401fe7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #7559 (cc47484) into main (5403c48) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7559      +/-   ##
==========================================
+ Coverage   93.28%   93.31%   +0.03%     
==========================================
  Files        1381     1381              
  Lines      119588   119589       +1     
==========================================
+ Hits       111554   111600      +46     
+ Misses       8034     7989      -45     
Impacted Files Coverage Δ
google/cloud/storage/internal/grpc_client_test.cc 100.00% <ø> (ø)
...oogle/cloud/storage/tests/grpc_integration_test.cc 97.76% <ø> (ø)
...torage/tests/object_basic_crud_integration_test.cc 81.36% <0.00%> (-0.51%) ⬇️
google/cloud/storage/internal/grpc_client.cc 92.04% <100.00%> (+6.59%) ⬆️
google/cloud/pubsub/samples/samples.cc 92.02% <0.00%> (-0.32%) ⬇️
...sub/internal/batching_publisher_connection_test.cc 99.60% <0.00%> (+0.19%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
.../cloud/storage/testing/storage_integration_test.cc 96.39% <0.00%> (+0.90%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e533a8...cc47484. Read the comment docs.

@coryan coryan marked this pull request as ready for review November 4, 2021 00:54
@coryan coryan requested a review from a team as a code owner November 4, 2021 00:54
@coryan coryan merged commit 6f47d5b into googleapis:main Nov 4, 2021
@coryan coryan deleted the fix-GCS+gRPC-correct-object-id-format branch November 4, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants