Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GCS+gRPC): implement BucketAccessControl parser #7763

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 20, 2021

Fixes #4174


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: dc13c430f5bff9788e23a36a1b749bce8d7b31f4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #7763 (dc13c43) into main (b2fe267) will decrease coverage by 0.00%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7763      +/-   ##
==========================================
- Coverage   95.15%   95.15%   -0.01%     
==========================================
  Files        1271     1273       +2     
  Lines      114633   114693      +60     
==========================================
+ Hits       109079   109136      +57     
- Misses       5554     5557       +3     
Impacted Files Coverage Δ
google/cloud/storage/bucket_access_control.h 100.00% <ø> (ø)
...gle/cloud/storage/internal/access_control_common.h 100.00% <ø> (ø)
...rage/internal/grpc_bucket_access_control_parser.cc 93.75% <93.75%> (ø)
...internal/grpc_bucket_access_control_parser_test.cc 100.00% <100.00%> (ø)
...le/cloud/storage/internal/curl_download_request.cc 88.69% <0.00%> (-1.07%) ⬇️
...sub/internal/batching_publisher_connection_test.cc 99.60% <0.00%> (+0.19%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 86.18% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2fe267...dc13c43. Read the comment docs.

@coryan coryan marked this pull request as ready for review December 20, 2021 15:08
@coryan coryan requested a review from a team as a code owner December 20, 2021 15:08
@coryan coryan merged commit 67dce82 into googleapis:main Dec 20, 2021
@coryan coryan deleted the feat-gcs-grpc-bucket-access-control-parser branch December 20, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ToProto/FromProto for storage::BucketAccessControl
3 participants