Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GCS+gRPC): implement BucketBilling parser #7765

Merged
merged 2 commits into from
Dec 20, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 20, 2021

Fixes #4164


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 5e4e0e00cad3bf67f3e9c381a2c553c60d25745b

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #7765 (f22c666) into main (67dce82) will increase coverage by 0.00%.
The diff coverage is 94.73%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7765   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files        1273     1275    +2     
  Lines      114693   114712   +19     
=======================================
+ Hits       109135   109157   +22     
+ Misses       5558     5555    -3     
Impacted Files Coverage Δ
...ud/storage/internal/grpc_bucket_metadata_parser.cc 88.88% <88.88%> (ø)
...orage/internal/grpc_bucket_metadata_parser_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/samples/samples.cc 92.10% <0.00%> (+0.07%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 86.18% <0.00%> (+0.65%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67dce82...f22c666. Read the comment docs.

@coryan coryan marked this pull request as ready for review December 20, 2021 17:27
@coryan coryan requested a review from a team as a code owner December 20, 2021 17:27
@@ -0,0 +1,47 @@
// Copyright 2019 Google LLC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/2019/2021/

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f22c66658bbb0136b783c98af504b6f1c3f40e78

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 508e008 into googleapis:main Dec 20, 2021
@coryan coryan deleted the feat-gcs+gRPC-bucket-billing-parser branch December 20, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ToProto/FromProto for storage::BucketBilling
3 participants