Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): support unified credentials #7824

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

devbww
Copy link
Contributor

@devbww devbww commented Jan 6, 2022

Fixes #6464.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jan 6, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d88fc35919935e0a9c70319691b44dcc647e0ace

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #7824 (dcc837c) into main (1a8817c) will increase coverage by 0.00%.
The diff coverage is 99.49%.

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #7824    +/-   ##
========================================
  Coverage   95.17%   95.18%            
========================================
  Files        1280     1283     +3     
  Lines      115463   115845   +382     
========================================
+ Hits       109895   110270   +375     
- Misses       5568     5575     +7     
Impacted Files Coverage Δ
google/cloud/spanner/internal/spanner_stub.h 100.00% <ø> (ø)
google/cloud/spanner/internal/spanner_auth.h 75.00% <75.00%> (ø)
.../spanner/benchmarks/multiple_rows_cpu_benchmark.cc 83.63% <100.00%> (+0.03%) ⬆️
google/cloud/spanner/client.cc 98.16% <100.00%> (+0.01%) ⬆️
...anner/integration_tests/client_integration_test.cc 96.30% <100.00%> (+0.06%) ⬆️
...integration_tests/session_pool_integration_test.cc 100.00% <100.00%> (ø)
google/cloud/spanner/internal/connection_impl.cc 94.88% <100.00%> (ø)
...gle/cloud/spanner/internal/connection_impl_test.cc 97.69% <100.00%> (+<0.01%) ⬆️
google/cloud/spanner/internal/spanner_auth.cc 100.00% <100.00%> (ø)
google/cloud/spanner/internal/spanner_auth_test.cc 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a8817c...dcc837c. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: dcc837c26e226dac14298fa7ab6662f0ae384ea1

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@devbww devbww marked this pull request as ready for review January 6, 2022 03:42
@devbww devbww requested a review from a team as a code owner January 6, 2022 03:42
Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@devbww devbww merged commit df5eb37 into googleapis:main Jan 6, 2022
@devbww devbww deleted the spanner-guac branch January 6, 2022 17:01
joezqren pushed a commit to joezqren/google-cloud-cpp that referenced this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use unified credentials in spanner
3 participants