Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): add missing options for PatchObject() #8137

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 27, 2022

After all these years, we were missing some options for
storage::Client::PatchObject(). They were in the documentation, but
trying to use them would have resulted in a compilation error.

Part of the work for #4195


This change is Reviewable

After all these years, we were missing some options for
`storage::Client::PatchObject()`.  They were in the documentation, but
trying to use them would have resulted in a compilation error.
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 27, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: a7efd6cbc4350d2521881f3820a51a2fe50c0cb7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jan 27, 2022

Codecov Report

Merging #8137 (a7efd6c) into main (950c774) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8137   +/-   ##
=======================================
  Coverage   94.58%   94.58%           
=======================================
  Files        1320     1320           
  Lines      117813   117827   +14     
=======================================
+ Hits       111433   111451   +18     
+ Misses       6380     6376    -4     
Impacted Files Coverage Δ
google/cloud/storage/client.h 99.79% <ø> (ø)
google/cloud/storage/internal/object_requests.h 97.10% <ø> (ø)
...gle/cloud/storage/internal/object_requests_test.cc 100.00% <100.00%> (ø)
...torage/tests/object_basic_crud_integration_test.cc 80.48% <100.00%> (+0.11%) ⬆️
google/cloud/pubsub/samples/samples.cc 92.33% <0.00%> (+0.23%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 950c774...a7efd6c. Read the comment docs.

@coryan coryan marked this pull request as ready for review January 27, 2022 23:29
@coryan coryan requested a review from a team as a code owner January 27, 2022 23:29
@coryan coryan merged commit eda004e into googleapis:main Jan 28, 2022
@coryan coryan deleted the fix-storage-patch-object-options branch January 28, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants