Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bigtable): duplicate AsyncRetryBulkApply #9244

Merged

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jun 10, 2022

Lay the ground work for #9175 . This is the same dance as we did in #9221 .

This PR copies the async_bulk_apply* files as new files with a legacy_ prefix. I will modify the async_bulk_apply* files in a subsequent PR to implement the retry loop helper in terms of the modern API (Stubs, common policies). The legacy_ files will exist for nearly a year until the deprecation policy expires on #8800.

It is broken into 2 commits. The reviewer can look at the first commit only to verify that the legacy_ files have no meaningful changes to them. The reviewer can look at the overall diff to verify that async_bulk_apply* have not changed at all. Also, we remove the async_bulk_apply* files from the builds to "prove" that they are not in use.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jun 10, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 12b018233f08e9121b4bd9ed79847d41668b5457

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #9244 (12b0182) into main (f29a2bb) will decrease coverage by 0.00%.
The diff coverage is 98.43%.

@@            Coverage Diff             @@
##             main    #9244      +/-   ##
==========================================
- Coverage   94.56%   94.56%   -0.01%     
==========================================
  Files        1457     1457              
  Lines      131699   131699              
==========================================
- Hits       124539   124538       -1     
- Misses       7160     7161       +1     
Impacted Files Coverage Δ
google/cloud/bigtable/table.cc 99.27% <ø> (ø)
.../bigtable/internal/legacy_async_bulk_apply_test.cc 98.13% <98.13%> (ø)
...cloud/bigtable/internal/legacy_async_bulk_apply.cc 100.00% <100.00%> (ø)
...cloud/pubsub/internal/subscription_session_test.cc 97.75% <0.00%> (-0.25%) ⬇️
google/cloud/bigtable/internal/async_bulk_apply.cc
...e/cloud/bigtable/internal/async_bulk_apply_test.cc

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29a2bb...12b0182. Read the comment docs.

@dbolduc dbolduc marked this pull request as ready for review June 10, 2022 04:42
@dbolduc dbolduc requested a review from a team as a code owner June 10, 2022 04:42
@dbolduc dbolduc merged commit 5d88584 into googleapis:main Jun 10, 2022
@dbolduc dbolduc deleted the bigtable-duplicate-async-retry-bulk-apply branch June 10, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants