-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generator): support explicit routing headers #9368
feat(generator): support explicit routing headers #9368
Conversation
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #9368 +/- ##
==========================================
- Coverage 94.68% 94.60% -0.09%
==========================================
Files 1480 1480
Lines 135483 135757 +274
==========================================
+ Hits 128285 128431 +146
- Misses 7198 7326 +128
Continue to review full report at Codecov.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to add tests for the async cases? Or streaming?
27d67fd
to
a6af996
Compare
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
I dropped the routing annotation on a streaming read and unary rpc where we generate async versions of the functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need to figure out streaming writes and streaming read-write RPCs, but those are (a) very rare, and (b) already broken I think.
Fixes #9121
The first and last commits are interesting. The middle two are not.
We do not pass our variables through
service_method_vars
. It is easier to work with the data directly.This change is