Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pubsub): missing subscription name in lease extensions #9523

Merged
merged 1 commit into from
Jul 20, 2022
Merged

fix(pubsub): missing subscription name in lease extensions #9523

merged 1 commit into from
Jul 20, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jul 19, 2022 •
edited
Loading

When I changed the lease extensions to use unary RPCs (as opposed to
inline messages in the streaming pull), I neglected to include the
subscription name with the request.

This change is Reviewable

@coryan
fix(pubsub): missing subscription name in lease extensions
0c192ef 
When I changed the lease extensions to use unary RPCs (as opposed to
inline messages in the streaming pull), I neglected to include the
subscription name with the request.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jul 19, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 0c192ef818bf815005fb76c6265694cf045759be

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 19, 2022 •
edited
Loading

Codecov Report

Merging #9523 (0c192ef) into main (6d076fc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #9523      +/-   ##
==========================================
- Coverage   94.62%   94.61%   -0.01%     
==========================================
  Files        1489     1489              
  Lines      137217   137218       +1     
==========================================
- Hits       129837   129834       -3     
- Misses       7380     7384       +4
Impacted Files Coverage Δ
...ub/internal/streaming_subscription_batch_source.cc 98.08% <100.00%> (+<0.01%) ⬆️
...ternal/streaming_subscription_batch_source_test.cc 99.86% <100.00%> (ø)
...e/cloud/spanner/testing/cleanup_stale_instances.cc 61.11% <0.00%> (-11.12%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 87.58% <0.00%> (-1.01%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.17%) ⬇️
google/cloud/internal/curl_impl.cc 91.87% <0.00%> (+0.22%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 98.31% <0.00%> (+0.56%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 86.18% <0.00%> (+0.65%) ⬆️
...loud/bigtable/internal/connection_refresh_state.cc 100.00% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d076fc...0c192ef. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 19, 2022 21:58
@coryan coryan requested a review from a team as a code owner July 19, 2022 21:58
@coryan coryan enabled auto-merge (squash) July 19, 2022 21:58
@coryan coryan merged commit 4dceea6 into googleapis:main Jul 20, 2022
@coryan coryan deleted the fix-pubsub-fix-modacks-as-unary-rpcs branch July 20, 2022 01:23
@coryan coryan mentioned this pull request Jul 20, 2022
Closed
coryan added a commit to coryan/google-cloud-cpp that referenced this pull request Jul 20, 2022
@coryan
fix(pubsub): missing subscription name in lease extensions (googleapi…
9cbeeee 
…s#9523)

When I changed the lease extensions to use unary RPCs (as opposed to
inline messages in the streaming pull), I neglected to include the
subscription name with the request.
coryan added a commit that referenced this pull request Jul 20, 2022
@coryan
fix(pubsub): missing subscription name in lease extensions (#9523) (#…
624d582 
…9533)

When I changed the lease extensions to use unary RPCs (as opposed to
inline messages in the streaming pull), I neglected to include the
subscription name with the request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coryan @google-cloud-cpp-bot @dbolduc