Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: update conformance tests #4905

Closed
frankyn opened this issue Apr 25, 2020 · 0 comments
Closed

storage: update conformance tests #4905

frankyn opened this issue Apr 25, 2020 · 0 comments
Assignees
@amanda-tarafa
Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@frankyn
Copy link
Member

frankyn commented Apr 25, 2020 •
edited
Loading

The Storage library support for Post Policy V4 has a security risk that is addressed in the latest PR to Storage conformance tests: googleapis/conformance-tests#31

The fix is to add {\"bucket\":\"bucket-name\"} to Post Policy V4 policy which is then signed.

Here's an example solution in Ruby: https://github.com/googleapis/google-cloud-ruby/pull/5803/files

@amanda-tarafa tracking issue as I know you're working on this right now. The conformance tests were updated.
@jskeet jskeet added the type: process A process-related concern. May include testing, release, or the like. label Apr 25, 2020
@amanda-tarafa amanda-tarafa added api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed type: process A process-related concern. May include testing, release, or the like. labels Apr 25, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. and removed triage me I really want to be triaged. labels Apr 27, 2020
@amanda-tarafa amanda-tarafa mentioned this issue Apr 29, 2020
Merged
amanda-tarafa added a commit to amanda-tarafa/google-cloud-dotnet that referenced this issue Apr 30, 2020
@amanda-tarafa
Adds POST policy V4 signing support.
c949794 
  * Fixes googleapis#4194.
  * Fixes googleapis#4905.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-tarafa amanda-tarafa

Labels
api: storage Issues related to the Cloud Storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jskeet @frankyn @amanda-tarafa @yoshi-automation