Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible docfx issue with latest SDK #8988

Closed
jskeet opened this issue Aug 15, 2022 · 4 comments · Fixed by #9090
Closed

Possible docfx issue with latest SDK #8988

jskeet opened this issue Aug 15, 2022 · 4 comments · Fixed by #9090
Assignees
Labels
type: process A process-related concern. May include testing, release, or the like.

Comments

@jskeet
Copy link
Collaborator

jskeet commented Aug 15, 2022

I'm using SDK 6.0.400 now, and I've just run into a problem running builddocs.sh:

[22-08-15 04:04:51.480]Warning:[ExtractMetadata](C:/Users/jonskeet/GitHub/googleapis/google-cloud-dotnet/apis/Google.Cloud.Functions.V2/Google.Cloud.Functions.V2/Google.Cloud.Functions.V2.csproj)Workspace failed with: [Failure] Msbuild failed when processing the file 'C:\Users\jonskeet\GitHub\googleapis\google-cloud-dotnet\apis\Google.Cloud.Functions.V2\Google.Cloud.Functions.V2\Google.Cloud.Functions.V2.csproj' with message: Method not found: 'System.ReadOnlySpan`1<Char> Microsoft.IO.Path.GetFileName(System.ReadOnlySpan`1<Char>)'.

Will try updating to a later docfx version...

@jskeet jskeet self-assigned this Aug 15, 2022
@jskeet jskeet added the type: process A process-related concern. May include testing, release, or the like. label Aug 15, 2022
@jskeet
Copy link
Collaborator Author

jskeet commented Aug 16, 2022

Looks like this is basically dotnet/docfx#8136

I'm hoping there'll be a new docfx release soon to fix this, but if not we may need to patch things - or pin to an earlier SDK, somehow...

@jskeet
Copy link
Collaborator Author

jskeet commented Aug 16, 2022

This shouldn't affect releasing though, so long as we know not to update to a more recent SDK in Kokoro.

@jskeet
Copy link
Collaborator Author

jskeet commented Aug 16, 2022

There's a potential workaround, which is to build the docs from the built DLLs instead of the project files.

We'd probably want to go via a "dotnet publish" step so that all the DLLs (with the right versions) are in the right directory. However, I think it's probably best to save that approach for a rainy day if we need it.

@jskeet
Copy link
Collaborator Author

jskeet commented Aug 18, 2022

I've added a workaround to #8136. We can use that to get local builds working temporarily. Hopefully there'll be a new release soon.

jskeet added a commit to jskeet/google-cloud-dotnet that referenced this issue Sep 9, 2022
jskeet added a commit that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant