Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigtable: emulator support for PingAndWarm #5802

Closed
dbolduc opened this issue Mar 28, 2022 · 0 comments · Fixed by #5803
Closed

bigtable: emulator support for PingAndWarm #5802

dbolduc opened this issue Mar 28, 2022 · 0 comments · Fixed by #5803
Assignees
@telpirion @dbolduc
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dbolduc
Copy link
Member

dbolduc commented Mar 28, 2022

PingAndWarm is now public, so we should support it in the emulator.

PingAndWarm acts on an Instance, not a Table. The real service validates whether the instance exists or not, but seeing as there is no way to create an instance with the emulator, I think the emulator PingAndWarm implementation should always return an OK response.
@dbolduc dbolduc added the triage me I really want to be triaged. label Mar 28, 2022
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Mar 28, 2022
This was referenced Mar 28, 2022
Merged
Closed
@telpirion telpirion added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Mar 30, 2022
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 28, 2022
@dbolduc
feat(bigtable): support PingAndWarm in emulator (#5803)
9b943d5 
Fixes #5802 

I do not check that the instance is in `s.instances`, because there is no way to create an instance. I do not think we want to require that users call `CreateInstance` before `CreateTable`, so we probably do not want to require that users call `CreateInstance` before `PingAndWarm` either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@telpirion telpirion

@dbolduc dbolduc

Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(bigtable): support PingAndWarm in emulator dbolduc/google-cloud-go
2 participants
@telpirion @dbolduc