feat(bigtable): add column family type to FamilyInfo in TableInfo #10182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponse Change-Id: Iaa688f27c3472717929fbbdd03f3e12b8402c34a
product-auto-label
bot
added
the
api: bigtable
|
Please add integration tests |
bhshkh
reviewed
May 16, 2024
| it := protoToType(agg.InputType) | ||
|
|
||
| var aggregator Aggregator | ||
| switch agg.Aggregator.(type) { |
There was a problem hiding this comment.
nil checks missing on agg and agg.Aggregator
| } | ||
|
|
||
| func int64EncodingProtoToEncoding(ie *btapb.Type_Int64_Encoding) Int64Encoding { | ||
| switch e := ie.Encoding.(type) { |
There was a problem hiding this comment.
nil checks missing on ie and ie.encoding
| } | ||
|
|
||
| func (ua unknownAggregator) fillProto(proto *btapb.Type_Aggregate) { | ||
| proto.Aggregator = ua.wrapped.Aggregator |
There was a problem hiding this comment.
having basically no experience writing go, what am I supposed to do if its nil?
There was a problem hiding this comment.
Please add nil checks wherever needed
|
This has been already added in #10520 Please reopen if something more needs to be added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds ValueType to FamilyInfo and populates it when calling TableInfo.
Internally it adds methods to convert from protobuf Type to our own type model.