fix(storage): retry broken pipe error #10374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another retryable net.OpError that can arise when a connection has been closed. So far we've only seen this in TestRetryConformance cases rather than in customer issues, but there is no reason not to do a retry and we think it can cut down on flakes from this test. I'm going to do another PR to add this to google-api-go-client since it often occurs on uploads. Updates googleapis#9178
product-auto-label
bot
added
the
api: storage
codyoss
approved these changes
Jun 12, 2024
tritone
added a commit
to tritone/google-api-go-client
that referenced
this pull request
Jun 12, 2024
A few fixes to shouldRetry, which is used only for storage uploads. * Remove attempt to unwrap syscall errors and use string matching instead, as is used in the veneer client layer for storage. * Use errors.Is and appropriate sentinel for net.ErrClosed. * Add broken pipe error, which is causing flakes in veneer layer tests (see googleapis/google-cloud-go#10374 * Add unit test for shouldRetry. Closes googleapis/google-cloud-go#9178
tritone
added a commit
to googleapis/google-api-go-client
that referenced
this pull request
Jun 12, 2024
* fix(storage): update shouldRetry for GCS uploads A few fixes to shouldRetry, which is used only for storage uploads. * Remove attempt to unwrap syscall errors and use string matching instead, as is used in the veneer client layer for storage. * Use errors.Is and appropriate sentinel for net.ErrClosed. * Add broken pipe error, which is causing flakes in veneer layer tests (see googleapis/google-cloud-go#10374 * Add unit test for shouldRetry. Closes googleapis/google-cloud-go#9178 * don't use xerrors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another retryable net.OpError that can arise when a connection has been closed. So far we've only seen this in TestRetryConformance cases rather than in customer issues, but there is no reason not to do a retry and we think it can cut down on flakes from this test.
I'm going to do another PR to add this to google-api-go-client since it often occurs on uploads.
Updates #9178