Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): check for grpc NotFound error in HMAC test #10645

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix(storage): check for grpc NotFound error in HMAC test #10645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2c4ba3
fix(storage): check for grpc NotFound error in HMAC test
BrennaEpp Aug 7, 2024
111db19
Merge branch 'main' into flaky-hmac
tritone Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storage/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5354,7 +5354,7 @@ func TestIntegration_HMACKey(t *testing.T) {
}

_, err = hkh.Get(ctx)
if err != nil && !strings.Contains(err.Error(), "404") {
if err != nil && !errorIsStatusCode(err, http.StatusNotFound, codes.NotFound) {
// If the deleted key has already been garbage collected, a 404 is expected.
// Other errors should cause a failure and are not expected.
t.Fatalf("Unexpected error: %v", err)
Expand Down
Loading