docs(all): update release instructions #3107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tbpg
suggested changes
Oct 29, 2020
RELEASING.md
Outdated
| automatically opened with a title like "chore: release 0.XX.0", where XX is the | ||
| next version to be released. To cut a release approve and merge this pull | ||
| request. Doing so will update the `CHANGES.md`, tag the merged commit with the | ||
| appropriate version , and draft a GitHub release. |
There was a problem hiding this comment.
Draft? Does the person doing the release need to do anything?
There was a problem hiding this comment.
I think the is the terminology used for releases. The button in Github to do this is Draft a release. And nope, it is done automagically. Here is an example of an automated github release: https://github.com/googleapis/google-cloud-go/releases/tag/v0.70.0
RELEASING.md
Outdated
|
|
||
| ### Automated Release | ||
|
|
||
| If there are changes that have not yet been released a pull request should be |
There was a problem hiding this comment.
Specify a PR from release-please? Link to those docs?
There was a problem hiding this comment.
Looks like this change wasn't uploaded?
Co-authored-by: Tyler Bui-Palsulich <26876514+tbpg@users.noreply.github.com>
tbpg
approved these changes
Oct 29, 2020
RELEASING.md
Outdated
| automatically opened with a title like "chore: release 0.XX.0", where XX is the | ||
| next version to be released. To cut a release, approve and merge this pull | ||
| request. Doing so will update the `CHANGES.md`, tag the merged commit with the | ||
| appropriate version , and draft a GitHub release. |
There was a problem hiding this comment.
Suggested change
| appropriate version , and draft a GitHub release. | |
| appropriate version, and draft a GitHub release. |
RELEASING.md
Outdated
|
|
||
| ### Automated Release | ||
|
|
||
| If there are changes that have not yet been released a pull request should be |
There was a problem hiding this comment.
Looks like this change wasn't uploaded?
|
They are live now, turns out it helps if you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.