feat(gkeconnect/gateway): start generating apiv1beta1 #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
noahdietz
approved these changes
Jun 8, 2021
codyoss
added
the
do not merge
|
@noahdietz For some reason the import for gatewaypb is not being generated into the imports. Any ideas why? Looks like the RPC don't deal with types from that package but just httpbody. Maybe that is why? |
|
Oop yes this was fixed in v0.20.2 of the generator. Turns out the proto has no request/response messages of its own (they are are |
|
No worries, thanks for the info! |
codyoss
added
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.