Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bigquery/storage/managedwriter): refactor error metrics #8314

Merged
merged 4 commits into from
Jul 25, 2023

Commits on Jul 21, 2023

  1. refactor(bigquery/storage/managedwriter): refactor error metrics

    This is a small refactor to how opencensus metrics are reported when
    receiving responses from the server.
    
    There's effectively two cases where we consider an error to have
    occurred on receive:
    
    * Invoking gRPC Recv() on the connection emitted an error, typically a
      transport issue
    
    * The service embedded an error in the response, which is more akin to
      an application error (failed to commit data, offset mismatch, etc).
    
    This CL ensures we increment the existing AppendResponseError count
    metric in both causes, and deals with the unlikely scenario where we're
    unable to tag the report with the status code.  When that happens, we
    simply record the metric uncoded.
    shollyman committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6f4801d View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    7830100 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Configuration menu
    Copy the full SHA
    42eee79 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8a2802c View commit details
    Browse the repository at this point in the history