Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): add universe domain to grpctransport and httptransport #9663

Merged
merged 13 commits into from
Apr 2, 2024

Conversation

quartzmo
Copy link
Member

@quartzmo quartzmo commented Mar 28, 2024

This pull request introduces an intentional breaking change by removing httptransport.InternalOptions.DefaultEndpoint and grpctransport.InternalOptions.DefaultEndpoint. This is because internaloption.WithDefaultEndpoint is now deprecated, and new code should instead use the combination of internaloption.WithDefaultEndpointTemplate and internaloption.WithDefaultUniverseDomain.

Adapted from: googleapis/google-api-go-client#2296

Fixes: #9670

@quartzmo quartzmo force-pushed the auth-impersonate-universe-domain branch 2 times, most recently from 295d89e to 5409485 Compare March 29, 2024 22:23
@quartzmo quartzmo force-pushed the auth-impersonate-universe-domain branch from 40cf26b to 4b1a44f Compare April 1, 2024 18:44
@quartzmo quartzmo marked this pull request as ready for review April 1, 2024 18:50
@quartzmo quartzmo requested a review from a team as a code owner April 1, 2024 18:50
auth/credentials/impersonate/impersonate_test.go Outdated Show resolved Hide resolved
auth/go.mod Outdated Show resolved Hide resolved
auth/grpctransport/grpctransport.go Show resolved Hide resolved
auth/grpctransport/grpctransport.go Outdated Show resolved Hide resolved
auth/internal/transport/cba.go Outdated Show resolved Hide resolved
auth/internal/transport/s2a_test.go Outdated Show resolved Hide resolved
auth/internal/transport/cba_test.go Outdated Show resolved Hide resolved
auth/internal/transport/cba_test.go Outdated Show resolved Hide resolved
auth/internal/transport/cba_test.go Outdated Show resolved Hide resolved
@quartzmo quartzmo force-pushed the auth-impersonate-universe-domain branch from 5d12b43 to a8ce8e1 Compare April 1, 2024 20:43
@quartzmo quartzmo force-pushed the auth-impersonate-universe-domain branch from e74e35d to 317a23d Compare April 1, 2024 22:02
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@quartzmo quartzmo changed the title feat(auth): add universe domain to impersonate and endpoint feat(auth): add universe domain to grpctransport and httptransport Apr 2, 2024
@quartzmo quartzmo merged commit 67d353b into googleapis:main Apr 2, 2024
8 of 9 checks passed
@quartzmo quartzmo deleted the auth-impersonate-universe-domain branch April 2, 2024 18:29
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 15, 2024
🤖 I have created a release *beep* *boop*
---


## [0.2.0](https://github.com/googleapis/google-cloud-go/compare/auth/v0.1.1...auth/v0.2.0) (2024-04-15)


### Features

* **auth/credentials/externalaccount:** Add default TokenURL ([#9700](https://github.com/googleapis/google-cloud-go/issues/9700)) ([81830e6](https://github.com/googleapis/google-cloud-go/commit/81830e6848ceefd055aa4d08f933d1154455a0f6))
* **auth:** Add downscope.Options.UniverseDomain ([#9634](https://github.com/googleapis/google-cloud-go/issues/9634)) ([52cf7d7](https://github.com/googleapis/google-cloud-go/commit/52cf7d780853594291c4e34302d618299d1f5a1d))
* **auth:** Add universe domain to grpctransport and httptransport ([#9663](https://github.com/googleapis/google-cloud-go/issues/9663)) ([67d353b](https://github.com/googleapis/google-cloud-go/commit/67d353beefe3b607c08c891876fbd95ab89e5fe3)), refs [#9670](https://github.com/googleapis/google-cloud-go/issues/9670)
* **auth:** Add UniverseDomain to DetectOptions ([#9536](https://github.com/googleapis/google-cloud-go/issues/9536)) ([3618d3f](https://github.com/googleapis/google-cloud-go/commit/3618d3f7061615c0e189f376c75abc201203b501))
* **auth:** Make package externalaccount public ([#9633](https://github.com/googleapis/google-cloud-go/issues/9633)) ([a0978d8](https://github.com/googleapis/google-cloud-go/commit/a0978d8e96968399940ebd7d092539772bf9caac))
* **auth:** Move credentials to base auth package ([#9590](https://github.com/googleapis/google-cloud-go/issues/9590)) ([1a04baf](https://github.com/googleapis/google-cloud-go/commit/1a04bafa83c27342b9308d785645e1e5423ea10d))
* **auth:** Refactor public sigs to use Credentials ([#9603](https://github.com/googleapis/google-cloud-go/issues/9603)) ([69cb240](https://github.com/googleapis/google-cloud-go/commit/69cb240c530b1f7173a9af2555c19e9a1beb56c5))


### Bug Fixes

* **auth/oauth2adapt:** Update protobuf dep to v1.33.0 ([30b038d](https://github.com/googleapis/google-cloud-go/commit/30b038d8cac0b8cd5dd4761c87f3f298760dd33a))
* **auth:** Fix uint32 conversion ([9221c7f](https://github.com/googleapis/google-cloud-go/commit/9221c7fa12cef9d5fb7ddc92f41f1d6204971c7b))
* **auth:** Port sts expires fix ([#9618](https://github.com/googleapis/google-cloud-go/issues/9618)) ([7bec97b](https://github.com/googleapis/google-cloud-go/commit/7bec97b2f51ed3ac4f9b88bf100d301da3f5d1bd))
* **auth:** Read universe_domain from all credentials files ([#9632](https://github.com/googleapis/google-cloud-go/issues/9632)) ([16efbb5](https://github.com/googleapis/google-cloud-go/commit/16efbb52e39ea4a319e5ee1e95c0e0305b6d9824))
* **auth:** Remove content-type header from idms get requests ([#9508](https://github.com/googleapis/google-cloud-go/issues/9508)) ([8589f41](https://github.com/googleapis/google-cloud-go/commit/8589f41599d265d7c3d46a3d86c9fab2329cbdd9))
* **auth:** Update protobuf dep to v1.33.0 ([30b038d](https://github.com/googleapis/google-cloud-go/commit/30b038d8cac0b8cd5dd4761c87f3f298760dd33a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth: detection of unset EXPERIMENTAL_GOOGLE_API_USE_S2A fails
2 participants