Set connect/read timeout when calling the metadata service (#4413)

Otherwise callers of these methods can be waiting indefinitely.
googleapis · Feb 8, 2019 · 44db769 · 44db769
1 parent d6b2c21
commit 44db769
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/MetadataConfig.java b/google-cloud-clients/google-cloud-core/src/main/java/com/google/cloud/MetadataConfig.java
@@ -34,6 +34,7 @@
 public class MetadataConfig {
 
   private static final String METADATA_URL = "http://metadata.google.internal/computeMetadata/v1/";
+  private static final int TIMEOUT_MS = 5000;
 
   private MetadataConfig() {}
 
@@ -69,6 +70,8 @@ public static String getAttribute(String attributeName) {
     try {
       URL url = new URL(METADATA_URL + attributeName);
       HttpURLConnection connection = (HttpURLConnection) url.openConnection();
+      connection.setConnectTimeout(TIMEOUT_MS);
+      connection.setReadTimeout(TIMEOUT_MS);
       connection.setRequestProperty("Metadata-Flavor", "Google");
       InputStream input = connection.getInputStream();
       if (connection.getResponseCode() == 200) {