Skip to content

Commit

Permalink
Reviewer comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jean-philippe-martin committed Apr 14, 2016
1 parent 86c2ba5 commit fc0af69
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@
@AutoService(FileSystemProvider.class)
public final class CloudStorageFileSystemProvider extends FileSystemProvider {

private final Storage storage;

// used only when we create a new instance of CloudStorageFileSystemProvider.
private static StorageOptions defaultStorageOptions;

private static class LazyPathIterator extends AbstractIterator<Path> {
private final Iterator<Blob> blobIterator;
private final Filter<? super Path> filter;
Expand Down Expand Up @@ -109,12 +114,6 @@ protected Path computeNext() {
}
}


private final Storage storage;

// used only when we create a new instance of CloudStorageFileSystemProvider.
private static StorageOptions defaultStorageOptions;

/**
* Sets default options that are only used by the constructor.
*/
Expand Down Expand Up @@ -575,9 +574,9 @@ public Iterator<Path> iterator() {
return new LazyPathIterator(cloudPath.getFileSystem(), blobIterator, filter);
}

// Does nothing since there's nothing to close. Commenting this method to quiet codacy.
@Override
public void close() throws IOException {
// Does nothing since there's nothing to close. Commenting this method to quiet codacy.
}
};
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ public Tuple<String, Iterable<StorageObject>> list(String bucket, Map<Option, ?>
if (preprefix.startsWith("/")) {
preprefix = preprefix.substring(1);
}
continue;
break;
case FIELDS:
// ignore and return all the fields
continue;
break;
default:
throw new UnsupportedOperationException("Unknown option: " + e.getKey());
}
Expand Down

0 comments on commit fc0af69

Please sign in to comment.