Allow users to set the scheduled executor service #1005
Assignees
Labels
Comments
|
+1 for creating an abstract options subclass of |
|
I have the feeling that we may need to have one top-level abstract service options and 2 other abstract sub classes for apiclient and gRPC. Aside from executor there are other differences such as the way timeout is handled. |
|
This was closed in #1011 |
github-actions bot
pushed a commit
that referenced
this issue
Aug 9, 2022
…1.0 (#1005) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-storage](https://github.com/googleapis/java-storage) | `2.10.0` -> `2.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-storage</summary> ### [`v2.11.0`](https://github.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#​2110-httpsgithubcomgoogleapisjava-storagecomparev2100v2110-2022-08-03) ##### Features - introduce RPC CancelResumableWriteRequest ([#​1518](https://github.com/googleapis/java-storage/issues/1518)) ([f8811c6](https://github.com/googleapis/java-storage/commit/f8811c654109516116bbbe142f4b27ec7f63b5fb)) ##### Documentation - Refactor Custom Dual Region sample to work with API changes ([#​1516](https://github.com/googleapis/java-storage/issues/1516)) ([a60cace](https://github.com/googleapis/java-storage/commit/a60caced9584855f12cdb7cac8ad7606ba32a60a)) ##### Dependencies - update dependency com.google.cloud:google-cloud-pubsub to v1.120.5 ([#​1527](https://github.com/googleapis/java-storage/issues/1527)) ([77072e3](https://github.com/googleapis/java-storage/commit/77072e3835bbeb802299fec1359c5f3ca13e3c8a)) - update dependency com.google.cloud:google-cloud-pubsub to v1.120.7 ([#​1530](https://github.com/googleapis/java-storage/issues/1530)) ([8c2ebad](https://github.com/googleapis/java-storage/commit/8c2ebad79affb766d842615aa30cc2a3dbe7d0de)) - update dependency com.google.cloud:google-cloud-pubsub to v1.120.8 ([#​1534](https://github.com/googleapis/java-storage/issues/1534)) ([723b100](https://github.com/googleapis/java-storage/commit/723b10014cafae257fa75d9c0bfd3fb0c34b9943)) - update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#​1526](https://github.com/googleapis/java-storage/issues/1526)) ([f7fc0d2](https://github.com/googleapis/java-storage/commit/f7fc0d2f301bd22e96a0b43f8657cc738f49f278)) - update dependency org.junit.vintage:junit-vintage-engine to v5.9.0 ([#​1524](https://github.com/googleapis/java-storage/issues/1524)) ([0e74093](https://github.com/googleapis/java-storage/commit/0e74093f3dffd829f8fb9f2525c1502e1910fbe6)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE0MS4wIn0=-->
github-actions bot
pushed a commit
that referenced
this issue
Aug 9, 2022
🤖 I have created a release *beep* *boop* --- ## [3.2.0](googleapis/java-aiplatform@v3.1.0...v3.2.0) (2022-08-09) ### Features * add a DeploymentResourcePool API resource_definition ([#997](googleapis/java-aiplatform#997)) ([82551d8](googleapis/java-aiplatform@82551d8)) * add DeploymentResourcePool in aiplatform v1beta1 deployment_resource_pool.proto ([#998](googleapis/java-aiplatform#998)) ([76dc64f](googleapis/java-aiplatform@76dc64f)) * add DeploymentResourcePoolService in aiplatform v1beta1 deployment_resource_pool_service.proto ([76dc64f](googleapis/java-aiplatform@76dc64f)) * add shared_resources for supported prediction_resources ([82551d8](googleapis/java-aiplatform@82551d8)) * add SHARED_RESOURCES to DeploymentResourcesType in aiplatform v1beta1 model.proto ([76dc64f](googleapis/java-aiplatform@76dc64f)) * added SHARED_RESOURCES enum to aiplatform v1 model.proto ([301cfb0](googleapis/java-aiplatform@301cfb0)) * DeploymentResourcePool and DeployementResourcePoolService added to aiplatform v1beta1 model.proto (cl/463147866) ([301cfb0](googleapis/java-aiplatform@301cfb0)) * making network arg optional in aiplatform v1 custom_job.proto ([#999](googleapis/java-aiplatform#999)) ([301cfb0](googleapis/java-aiplatform@301cfb0)) * making network arg optional in aiplatform v1beta1 custom_job.proto ([301cfb0](googleapis/java-aiplatform@301cfb0)) * **samples:** add all feature samples ([#980](googleapis/java-aiplatform#980)) ([8c2a485](googleapis/java-aiplatform@8c2a485)) * **samples:** add all feature values samples ([#981](googleapis/java-aiplatform#981)) ([2d4e6fe](googleapis/java-aiplatform@2d4e6fe)) ### Bug Fixes * declaring test-scope artifact as runtime ([#1014](googleapis/java-aiplatform#1014)) ([6c47c65](googleapis/java-aiplatform@6c47c65)) ### Documentation * doc edits to aiplatform v1 dataset_service.proto, job_service.proto, model_service.proto, pipeline_service.proto, saved_query.proto, study.proto, types.proto ([301cfb0](googleapis/java-aiplatform@301cfb0)) * doc edits to aiplatform v1beta1 job_service.proto, model_service.proto, pipeline_service.proto, saved_query.proto, study.proto, types.proto ([301cfb0](googleapis/java-aiplatform@301cfb0)) ### Dependencies * update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.17.0 ([#1003](googleapis/java-aiplatform#1003)) ([b793732](googleapis/java-aiplatform@b793732)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1006](googleapis/java-aiplatform#1006)) ([6bb8982](googleapis/java-aiplatform@6bb8982)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1009](googleapis/java-aiplatform#1009)) ([8cca8b5](googleapis/java-aiplatform@8cca8b5)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1000](googleapis/java-aiplatform#1000)) ([c93de30](googleapis/java-aiplatform@c93de30)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#1004](googleapis/java-aiplatform#1004)) ([dd52cad](googleapis/java-aiplatform@dd52cad)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#1005](googleapis/java-aiplatform#1005)) ([60e2f76](googleapis/java-aiplatform@60e2f76)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#1008](googleapis/java-aiplatform#1008)) ([9a2fe64](googleapis/java-aiplatform@9a2fe64)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#1010](googleapis/java-aiplatform#1010)) ([3c2ac16](googleapis/java-aiplatform@3c2ac16)) * update dependency com.google.code.gson:gson to v2.9.1 ([#1001](googleapis/java-aiplatform#1001)) ([a6ffed4](googleapis/java-aiplatform@a6ffed4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Oct 4, 2022
🤖 I have created a release *beep* *boop* --- ## [2.2.10](https://github.com/googleapis/java-video-intelligence/compare/v2.2.9...v2.2.10) (2022-09-30) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.16 ([#1001](https://github.com/googleapis/java-video-intelligence/issues/1001)) ([0b5270b](https://github.com/googleapis/java-video-intelligence/commit/0b5270bd724b7864d5178461b64e0b24a2b5d1f6)) * Update dependency com.google.cloud:google-cloud-core to v2.8.17 ([#1005](https://github.com/googleapis/java-video-intelligence/issues/1005)) ([ae79283](https://github.com/googleapis/java-video-intelligence/commit/ae79283d504f455856d9a18754ee7373a63d550d)) * Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#1029](https://github.com/googleapis/java-video-intelligence/issues/1029)) ([cf3e335](https://github.com/googleapis/java-video-intelligence/commit/cf3e3355cd81eff047682945d48532912edfe044)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this issue
Oct 12, 2022
](https://renovatebot.com){kind=link}
* chore: Update blunderbuss with issues/pr reviewer Update reviewers with googleapis/api-logging-reviewers * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
….6.7 (#1005) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-iam-v1](https://github.com/googleapis/java-iam/proto-google-iam-v1) ([source](https://github.com/googleapis/java-iam)) | `1.6.6` -> `1.6.7` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-iam</summary> ### [`v1.6.7`](https://github.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#​167-httpsgithubcomgoogleapisjava-iamcomparev166v167-2022-10-31) [Compare Source](https://github.com/googleapis/java-iam/compare/v1.6.6...v1.6.7) ##### Dependencies - Update dependency com.google.api:api-common to v2.2.2 ([#​497](https://github.com/googleapis/java-iam/issues/497)) ([bfcb37f](https://github.com/googleapis/java-iam/commit/bfcb37f9d46553a13a51bc8c437b6af046cb3c6c)) - Update dependency com.google.cloud:google-iam-policy to v1.6.6 ([#​492](https://github.com/googleapis/java-iam/issues/492)) ([cb7b782](https://github.com/googleapis/java-iam/commit/cb7b782017eb0ecf4914e4a1de252706bec70d6f)) - Update dependency com.google.http-client:google-http-client-jackson2 to v1.42.3 ([#​498](https://github.com/googleapis/java-iam/issues/498)) ([002b226](https://github.com/googleapis/java-iam/commit/002b2266fd9db19bade62e219970e7050d2bbbc0)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.9 ([#​495](https://github.com/googleapis/java-iam/issues/495)) ([ef4f95b](https://github.com/googleapis/java-iam/commit/ef4f95b393a02b96f41743b3bcd8349dda0f9822)) - Update dependency com.google.protobuf:protobuf-java to v3.21.9 ([#​493](https://github.com/googleapis/java-iam/issues/493)) ([fb776ce](https://github.com/googleapis/java-iam/commit/fb776ce04129a55ea9ff0b964df624b64b5865a4)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45LjIiLCJ1cGRhdGVkSW5WZXIiOiIzNC4xOS4wIn0=-->
suztomo
pushed a commit
that referenced
this issue
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ## [2.8.26](https://github.com/googleapis/java-core/compare/v2.8.25...v2.8.26) (2022-11-07) ### Dependencies * Update dependency com.google.api-client:google-api-client-bom to v2.0.1 ([#1011](https://github.com/googleapis/java-core/issues/1011)) ([bbcaed9](https://github.com/googleapis/java-core/commit/bbcaed9a9688a054adbb8d4615af14566b98a297)) * Update dependency com.google.api.grpc:proto-google-common-protos to v2.10.0 ([#1010](https://github.com/googleapis/java-core/issues/1010)) ([1f41e6b](https://github.com/googleapis/java-core/commit/1f41e6b9bf86ea94dbd0efda348d46f04e62baa4)) * Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.6.7 ([#1005](https://github.com/googleapis/java-core/issues/1005)) ([aac06c2](https://github.com/googleapis/java-core/commit/aac06c231ae59e4e913a228328202bdceda39ec4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
grpc-based services use a
ScheduledExecutorService. We should allow users to set an executor other than the default one in the service options.Related to this: should we create an abstract option class for grpc-based services (that extends
ServiceOptions?) That could expose some of the grpc-only configurations like setting the executor or converting the connection timeouts (see here)./cc @aozarov @ajkannan
The text was updated successfully, but these errors were encountered: