Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging class names #1047

Closed
shinfan opened this issue Jun 8, 2016 · 2 comments
Closed

Fix logging class names #1047

shinfan opened this issue Jun 8, 2016 · 2 comments
Assignees
@yoshi-automation
Labels
api: logging Issues related to the Cloud Logging API.

Comments

@shinfan
Copy link
Contributor

shinfan commented Jun 8, 2016

The logging class name contains a "v2" suffix which is inconsistent with other APIs (pubsub in particular). We can fix this issue by:

  1. Contact the logging team to fix the name in the proto.
  2. Override the name in the generation phase.
@shinfan shinfan mentioned this issue Jun 8, 2016
Merged
@mziccard mziccard added the api: logging Issues related to the Cloud Logging API. label Aug 26, 2016
@garrettjonesgoogle
Copy link
Member

Provisionally marking as 'blocking GA'.

@lesv
Copy link
Contributor

lesv commented Feb 27, 2017

Option 2 is recommended.

@michaelbausor michaelbausor mentioned this issue Mar 8, 2017
Merged
github-actions bot pushed a commit to renovate-bot/google-cloud-java that referenced this issue Oct 8, 2022
@release-please
chore(main): release 2.2.14-SNAPSHOT (googleapis#1047)
f8730fa 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Nov 22, 2022
@renovate-bot @gcf-owl-bot @Shabirmean
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
c4c3230 
…onfig to v1.5.4 (#1047)

* build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.5.4

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* deps: update google-cloud-shared-dependencies to v3.0.5

Combining updates from googleapis/java-vision#1049 into the same PR

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Shabir Mohamed Abdul Samadh <7249208+Shabirmean@users.noreply.github.com>
suztomo pushed a commit that referenced this issue Feb 1, 2023
@renovate-bot
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
42faafa 
…onfig to v1.5.5 (#1047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: logging Issues related to the Cloud Logging API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@mziccard @lesv @shinfan @pongad @danoscarmike @garrettjonesgoogle @michaelbausor @yoshi-automation