Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow CloudStorageFileSystemProvider without credentials #1188

Closed
jean-philippe-martin opened this issue Aug 23, 2016 · 4 comments
Closed

Allow CloudStorageFileSystemProvider without credentials #1188

jean-philippe-martin opened this issue Aug 23, 2016 · 4 comments
Assignees
@mziccard

Comments

@jean-philippe-martin
Copy link

When using any NIO Filesystem provider, Java will enumerate them all and try to create them.

Our CloudStorageFileSystemProvider will throw an exception if there is no GOOGLE_APPLICATION_CREDENTIALS environment variable (because then it can't find credentials). This seems reasonable at first but here this means that even if someone is not using gs:// at all, just by having our jar in the classpath they become unable to use other filesystem providers.

This issue shows a concrete instance, with example.

This suggests we need to allow CloudStorageFileSystemProvider to be created without credentials. We can fail later, when the user tries to get a CloudStorageFileSystem instance.

Sounds good?

cc: @jart, @mziccard
@jart
Copy link

jart commented Aug 23, 2016

Sgtm

On Aug 23, 2016 10:38 AM, "JP Martin" notifications@github.com wrote:

When using any NIO Filesystem provider, Java will enumerate them all and
try to create them.

Our CloudStorageFileSystemProvider will throw an exception if there is no
GOOGLE_APPLICATION_CREDENTIALS environment variable (because then it
can't find credentials). This seems reasonable at first but here this means
that even if someone is not using gs:// at all, just by having our jar in
the classpath they become unable to use other filesystem providers.

This issue broadinstitute/gatk#2110 shows a
concrete instance, with example.

This suggests we need to allow CloudStorageFileSystemProvider to be
created without credentials. We can fail later, when the user tries to get
a CloudStorageFileSystem instance.

Sounds good?

cc: @jart https://github.com/jart, @mziccard
https://github.com/mziccard

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1188, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADAboGdGLsF9VmVLcOFaEvMN13sECPHks5qizAtgaJpZM4JrMNZ
.

@mziccard
Copy link
Contributor

This suggests we need to allow CloudStorageFileSystemProvider to be created without credentials. We can fail later, when the user tries to get a CloudStorageFileSystem instance.

Sounds reasonable to me. Happy to review a PR :)

Merged
@jean-philippe-martin
Copy link
Author

Thanks to you both! And @mziccard since you offered so kindly I assigned you to my pull request, #1189.

@mziccard
Copy link
Contributor

This was fixed by #1189 thanks to @jean-philippe-martin.

github-actions bot pushed a commit that referenced this issue Jul 20, 2022
@renovate-bot
build(deps): update dependency org.apache.maven.plugins:maven-deploy-…
188e881 
…plugin to v3 (#1188)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `2.8.2` -> `3.0.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mziccard mziccard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jart @mziccard @jean-philippe-martin