Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [container] add secondary boot disks field to NodePool API #10422

Merged
merged 6 commits into from
Feb 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java-container/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.32.0</version>
<version>26.33.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -195,7 +195,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-container.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-container/2.38.0
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-container/2.39.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1410,6 +1410,7 @@ public final UnaryCallable<UpdateClusterRequest, Operation> updateClusterCallabl
* .setDiskType("diskType279771767")
* .setDiskSizeGb(-757478089)
* .setResourceManagerTags(ResourceManagerTags.newBuilder().build())
* .setQueuedProvisioning(NodePool.QueuedProvisioning.newBuilder().build())
* .build();
* Operation response = clusterManagerClient.updateNodePool(request);
* }
Expand Down Expand Up @@ -1465,6 +1466,7 @@ public final Operation updateNodePool(UpdateNodePoolRequest request) {
* .setDiskType("diskType279771767")
* .setDiskSizeGb(-757478089)
* .setResourceManagerTags(ResourceManagerTags.newBuilder().build())
* .setQueuedProvisioning(NodePool.QueuedProvisioning.newBuilder().build())
* .build();
* ApiFuture<Operation> future =
* clusterManagerClient.updateNodePoolCallable().futureCall(request);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1297,6 +1297,7 @@ public final UnaryCallable<UpdateClusterRequest, Operation> updateClusterCallabl
* .setDiskType("diskType279771767")
* .setDiskSizeGb(-757478089)
* .setResourceManagerTags(ResourceManagerTags.newBuilder().build())
* .setQueuedProvisioning(NodePool.QueuedProvisioning.newBuilder().build())
* .build();
* Operation response = clusterManagerClient.updateNodePool(request);
* }
Expand Down Expand Up @@ -1352,6 +1353,7 @@ public final Operation updateNodePool(UpdateNodePoolRequest request) {
* .setDiskType("diskType279771767")
* .setDiskSizeGb(-757478089)
* .setResourceManagerTags(ResourceManagerTags.newBuilder().build())
* .setQueuedProvisioning(NodePool.QueuedProvisioning.newBuilder().build())
* .build();
* ApiFuture<Operation> future =
* clusterManagerClient.updateNodePoolCallable().futureCall(request);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3509,6 +3509,33 @@
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.container.v1beta1.SecondaryBootDisk",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.container.v1beta1.SecondaryBootDisk$Builder",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.container.v1beta1.SecondaryBootDisk$Mode",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.container.v1beta1.SecurityBulletinEvent",
"queryAllDeclaredConstructors": true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,7 @@ public void updateNodePoolTest() throws Exception {
.setDiskType("diskType279771767")
.setDiskSizeGb(-757478089)
.setResourceManagerTags(ResourceManagerTags.newBuilder().build())
.setQueuedProvisioning(NodePool.QueuedProvisioning.newBuilder().build())
.build();

Operation actualResponse = client.updateNodePool(request);
Expand Down Expand Up @@ -785,6 +786,7 @@ public void updateNodePoolTest() throws Exception {
Assert.assertEquals(request.getDiskType(), actualRequest.getDiskType());
Assert.assertEquals(request.getDiskSizeGb(), actualRequest.getDiskSizeGb());
Assert.assertEquals(request.getResourceManagerTags(), actualRequest.getResourceManagerTags());
Assert.assertEquals(request.getQueuedProvisioning(), actualRequest.getQueuedProvisioning());
Assert.assertTrue(
channelProvider.isHeaderSent(
ApiClientHeaderProvider.getDefaultApiClientHeaderKey(),
Expand Down Expand Up @@ -827,6 +829,7 @@ public void updateNodePoolExceptionTest() throws Exception {
.setDiskType("diskType279771767")
.setDiskSizeGb(-757478089)
.setResourceManagerTags(ResourceManagerTags.newBuilder().build())
.setQueuedProvisioning(NodePool.QueuedProvisioning.newBuilder().build())
.build();
client.updateNodePool(request);
Assert.fail("No exception raised");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,7 @@ public void updateNodePoolTest() throws Exception {
.setDiskType("diskType279771767")
.setDiskSizeGb(-757478089)
.setResourceManagerTags(ResourceManagerTags.newBuilder().build())
.setQueuedProvisioning(NodePool.QueuedProvisioning.newBuilder().build())
.build();

Operation actualResponse = client.updateNodePool(request);
Expand Down Expand Up @@ -558,6 +559,7 @@ public void updateNodePoolTest() throws Exception {
Assert.assertEquals(request.getDiskType(), actualRequest.getDiskType());
Assert.assertEquals(request.getDiskSizeGb(), actualRequest.getDiskSizeGb());
Assert.assertEquals(request.getResourceManagerTags(), actualRequest.getResourceManagerTags());
Assert.assertEquals(request.getQueuedProvisioning(), actualRequest.getQueuedProvisioning());
Assert.assertTrue(
channelProvider.isHeaderSent(
ApiClientHeaderProvider.getDefaultApiClientHeaderKey(),
Expand Down Expand Up @@ -600,6 +602,7 @@ public void updateNodePoolExceptionTest() throws Exception {
.setDiskType("diskType279771767")
.setDiskSizeGb(-757478089)
.setResourceManagerTags(ResourceManagerTags.newBuilder().build())
.setQueuedProvisioning(NodePool.QueuedProvisioning.newBuilder().build())
.build();
client.updateNodePool(request);
Assert.fail("No exception raised");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ public com.google.container.v1.HorizontalPodAutoscaling getHorizontalPodAutoscal
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1196
* google/container/v1/cluster_service.proto;l=1200
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Override
Expand All @@ -213,7 +213,7 @@ public boolean hasKubernetesDashboard() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1196
* google/container/v1/cluster_service.proto;l=1200
* @return The kubernetesDashboard.
*/
@java.lang.Override
Expand Down Expand Up @@ -1928,7 +1928,7 @@ public Builder clearHorizontalPodAutoscaling() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1196
* google/container/v1/cluster_service.proto;l=1200
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Deprecated
Expand All @@ -1950,7 +1950,7 @@ public boolean hasKubernetesDashboard() {
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1196
* google/container/v1/cluster_service.proto;l=1200
* @return The kubernetesDashboard.
*/
@java.lang.Deprecated
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public interface AddonsConfigOrBuilder
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1196
* google/container/v1/cluster_service.proto;l=1200
* @return Whether the kubernetesDashboard field is set.
*/
@java.lang.Deprecated
Expand All @@ -138,7 +138,7 @@ public interface AddonsConfigOrBuilder
* </code>
*
* @deprecated google.container.v1.AddonsConfig.kubernetes_dashboard is deprecated. See
* google/container/v1/cluster_service.proto;l=1196
* google/container/v1/cluster_service.proto;l=1200
* @return The kubernetesDashboard.
*/
@java.lang.Deprecated
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ public com.google.container.v1.NodeManagementOrBuilder getManagementOrBuilder()
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @return The minCpuPlatform.
*/
@java.lang.Override
Expand Down Expand Up @@ -346,7 +346,7 @@ public java.lang.String getMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @return The bytes for minCpuPlatform.
*/
@java.lang.Override
Expand Down Expand Up @@ -1963,7 +1963,7 @@ public com.google.container.v1.NodeManagementOrBuilder getManagementOrBuilder()
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @return The minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -1998,7 +1998,7 @@ public java.lang.String getMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @return The bytes for minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -2033,7 +2033,7 @@ public com.google.protobuf.ByteString getMinCpuPlatformBytes() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @param value The minCpuPlatform to set.
* @return This builder for chaining.
*/
Expand Down Expand Up @@ -2067,7 +2067,7 @@ public Builder setMinCpuPlatform(java.lang.String value) {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @return This builder for chaining.
*/
@java.lang.Deprecated
Expand Down Expand Up @@ -2097,7 +2097,7 @@ public Builder clearMinCpuPlatform() {
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @param value The bytes for minCpuPlatform to set.
* @return This builder for chaining.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ public interface AutoprovisioningNodePoolDefaultsOrBuilder
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @return The minCpuPlatform.
*/
@java.lang.Deprecated
Expand All @@ -215,7 +215,7 @@ public interface AutoprovisioningNodePoolDefaultsOrBuilder
* <code>string min_cpu_platform = 5 [deprecated = true];</code>
*
* @deprecated google.container.v1.AutoprovisioningNodePoolDefaults.min_cpu_platform is
* deprecated. See google/container/v1/cluster_service.proto;l=3933
* deprecated. See google/container/v1/cluster_service.proto;l=3940
* @return The bytes for minCpuPlatform.
*/
@java.lang.Deprecated
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ private EvaluationMode(int value) {
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1450
* google/container/v1/cluster_service.proto;l=1454
* @return The enabled.
*/
@java.lang.Override
Expand Down Expand Up @@ -664,7 +664,7 @@ public Builder mergeFrom(
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1450
* google/container/v1/cluster_service.proto;l=1454
* @return The enabled.
*/
@java.lang.Override
Expand All @@ -684,7 +684,7 @@ public boolean getEnabled() {
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1450
* google/container/v1/cluster_service.proto;l=1454
* @param value The enabled to set.
* @return This builder for chaining.
*/
Expand All @@ -708,7 +708,7 @@ public Builder setEnabled(boolean value) {
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1450
* google/container/v1/cluster_service.proto;l=1454
* @return This builder for chaining.
*/
@java.lang.Deprecated
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public interface BinaryAuthorizationOrBuilder
* <code>bool enabled = 1 [deprecated = true];</code>
*
* @deprecated google.container.v1.BinaryAuthorization.enabled is deprecated. See
* google/container/v1/cluster_service.proto;l=1450
* google/container/v1/cluster_service.proto;l=1454
* @return The enabled.
*/
@java.lang.Deprecated
Expand Down
Loading
Loading