Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [shopping-merchant-quota] new module for shopping-merchant-quota #10575

Merged
merged 4 commits into from
Mar 19, 2024
Merged

feat: [shopping-merchant-quota] new module for shopping-merchant-quota #10575

merged 4 commits into from
Mar 19, 2024

Conversation

cloud-java-bot
Copy link
Collaborator

Generated by @diegomarquezp via generate_new_client_hermetic_build.yaml

Command used:

python generation/new_client_hermetic_build/add-new-client-config.py add-new-client --api-shortname "shopping-merchant-quota" --name-pretty "Merchant Quota API" --api-description "Programmatically manage your Merchant Center accounts." --proto-path "google/shopping/merchant/quota/v1beta" --product-docs "https://developers.google.com/merchant/api" --distribution-name "com.google.shopping:google-shopping-merchant-quota" 

docker run --rm \
  -v repo-google-cloud-java:/workspace/google-cloud-java \
  -v /tmp:/tmp \
  -v /var/run/docker.sock:/var/run/docker.sock \
  -e "RUNNING_IN_DOCKER=true" \
  -e "REPO_BINDING_VOLUMES=-v repo-google-cloud-java:/workspace/google-cloud-java" \
  gcr.io/cloud-devrel-public-resources/java-library-generation:latest \
  python /src/generate_repo.py generate \
  --generation-config-yaml=/workspace/google-cloud-java/generation_config.yaml \
  --repository-path=/workspace/google-cloud-java \
  --target-library-api-shortname=shopping-merchant-quota

@cloud-java-bot cloud-java-bot requested a review from a team as a code owner March 19, 2024 20:03
@cloud-java-bot cloud-java-bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 19, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Mar 19, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@diegomarquezp diegomarquezp enabled auto-merge (squash) March 19, 2024 20:10
blakeli0
blakeli0 reviewed Mar 19, 2024
View reviewed changes
generation_config.yaml
@@ -170,7 +170,8 @@ libraries:
- api_shortname: apphub
name_pretty: App Hub API
product_documentation: https://cloud.google.com/app-hub/docs/overview
api_description: App Hub simplifies the process of building, running, and managing applications on Google Cloud.
api_description: App Hub simplifies the process of building, running, and managing
Copy link
Contributor

@blakeli0 blakeli0 Mar 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what triggers this format change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's the default behavior of ruamel.yaml, the library used to add a new entry to the config yaml.
ruaml.yaml inherits from PyYaml. The docs explain we can use the width argument when dumping the yaml to prevent long lines from being split

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had enabled automerge for this PR and it got merged before I answered. I can follow up by adding a fix to prevent string formatting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with it as long as this format change does not mess up @JoeWang1127 's comparator.

@diegomarquezp diegomarquezp merged commit 0dd7a94 into main Mar 19, 2024
30 of 31 checks passed
@diegomarquezp diegomarquezp deleted the new-library/shopping-merchant-quota-TZhnH branch March 19, 2024 20:37
@release-please release-please bot mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

@blakeli0 blakeli0 blakeli0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cloud-java-bot @blakeli0 @diegomarquezp