Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PubSub examples, update READMEs and package-info javadoc #1075

Merged
merged 2 commits into from
Jun 24, 2016
Merged

Add PubSub examples, update READMEs and package-info javadoc #1075

merged 2 commits into from
Jun 24, 2016

Conversation

mziccard
Copy link
Contributor

No description provided.

@mziccard mziccard added docs api: pubsub Issues related to the Pub/Sub API. labels Jun 23, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0009%) to 85.98% when pulling a24c822 on mziccard:pubsub-examples into 7de0d45 on GoogleCloudPlatform:pubsub-alpha.

@mziccard
Copy link
Contributor Author

/cc @lesv

@lesv
Copy link
Contributor

lesv commented Jun 23, 2016

LGTM - comments:

  1. I wish Github allowed :include in their markdown
  2. We will probably need to reformat the snippets a bit when we publish or at least add doc tags, but that's a bit in the future.

Thanks -- looks good.

@mziccard
Copy link
Contributor Author

  1. I wish Github allowed :include in their markdown

You're not alone :) github/markup#172 (comment)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 86.124% when pulling 3dc4ce5 on mziccard:pubsub-examples into 7de0d45 on GoogleCloudPlatform:pubsub-alpha.

@mziccard mziccard merged commit 42f0fe8 into googleapis:pubsub-alpha Jun 24, 2016
mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jun 27, 2016
@mziccard
Add PubSub examples, update READMEs and package-info javadoc (googlea…
57883ae 
…pis#1075)
github-actions bot pushed a commit that referenced this pull request Sep 15, 2022
@gcf-owl-bot
chore: Generated snippets should not be owned by samples reviewers (#…
7944165 
…1575) (#1075)

Source-Link: googleapis/synthtool@2e9ac19
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mziccard @coveralls @lesv @googlebot