Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StreamingBuffer to allow oldestEntryTime to be null #1141

Merged
merged 1 commit into from
Aug 9, 2016

Conversation

mziccard
Copy link
Contributor

@mziccard mziccard commented Aug 8, 2016

This fixes #1131.

@mtagle @criccomini this should solve your issue.

@mziccard mziccard added the api: bigquery Issues related to the BigQuery API. label Aug 8, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 8, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 85.873% when pulling 9679852 on mziccard:fix-streaming-buffer into 64115e4 on GoogleCloudPlatform:master.

@criccomini
Copy link

LGTM

@criccomini
Copy link

Can you say when this patch might be released? We're currently running a patched version.

@mziccard
Copy link
Contributor Author

mziccard commented Aug 8, 2016

@criccomini A sound guess could be end of this week. I have a bunch of issues that I plan on fixing this week and hopefully release a new version containing all of them by Friday.

@mziccard
Copy link
Contributor Author

mziccard commented Aug 8, 2016

/cc @lesv

@lesv
Copy link
Contributor

lesv commented Aug 8, 2016

LGTM

@mziccard mziccard merged commit 0637c80 into googleapis:master Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when calling com.google.cloud.bigquery.BigQuery.getTable(...)
5 participants