Change pubsub endpoint from pubsub-experimental to pubsub

[mziccard]

This change will be also made at the Veneer Toolkit level at next code-generation round. While we wait for that we go ahead and override the endpoint.

For reference: pubsub-experimental.googleapis.com stopped working today with the following error:

com.google.cloud.pubsub.PubSubException: io.grpc.StatusRuntimeException: PERMISSION_DENIED: Google Cloud Pub/Sub API (Experimental) has not been used in project google.com:gcloud-devel before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/pubsub-experimental.googleapis.com/overview?project=gcloud-devel then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.

See this comment and this StackOverflow question.

[coveralls]

Coverage decreased (-0.009%) to 85.864% when pulling 8959fec on mziccard:fix-pubsub-endpoint into 0637c80 on GoogleCloudPlatform:master.

[mziccard]

Please @lesv can you have a look at this?

[mziccard]

@garrettjonesgoogle would you also mind having a quick look?

[garrettjonesgoogle]

Why not just edit the line in PublisherSettings & SubscriberSettings with the default host?

[mziccard]

Why not just edit the line in PublisherSettings & SubscriberSettings with the default host?

This way we also support setting other hosts using the host() setter in the option builder (even though it should not be needed). And I wanted to avoid conflicts with the autogen code.

[garrettjonesgoogle]

Why not just edit the line in PublisherSettings & SubscriberSettings with the default host?

This way we also support setting other hosts using the host() setter in the option builder (even though it should not be needed). And I wanted to avoid conflicts with the autogen code.

Ok it makes sense to plumb through the host from the options. But, my preference would be for PubSubOptions.DEFAULT_HOST to be set to PublisherSettings.DEFAULT_SERVICE_ADDRESS.

If you simply edit the DEFAULT_SERVICE_ADDRESS value e.g. at https://github.com/GoogleCloudPlatform/gcloud-java/blob/master/gcloud-java-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/PublisherSettings.java#L112 , then it should match what the generator will output in the next generation, and there won't be a conflict.

That said, it's not a strong opinion, and we can edit the veneer code when we generate next time.

[garrettjonesgoogle]

LGTM since this issue needs to be fixed urgently

[teddziuba]

Confirmed this fixes #1150. I hand built 0.2.7-SNAPSHOT and deployed it in my app. Looking forward to the next release.

[trentonstrong]

Thanks for fixing this so quickly! Appreciate it.