Support listing/getting/creating/updating tables/datasets/jobs in other projects #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mziccard
force-pushed
the
bigquery-project-id
branch
from
099178b to
d6576ce
Compare
|
LGTM |
| @@ -265,13 +274,15 @@ public boolean delete(String datasetId, DatasetDeleteOption... options) { | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean delete(final DatasetId datasetId, DatasetDeleteOption... options) { | |||
| public boolean delete(DatasetId datasetId, DatasetDeleteOption... options) { | |||
| final DatasetId completeDatasetId = datasetId.setProjectId(options().projectId()); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1123
@tswast feel free to have a look and comment whether this meets your expectations.
/cc @lesv