Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Sink.update/delete and add snippets for Sink class #1222

Merged
merged 3 commits into from
Sep 5, 2016
Merged

Fix Sink.update/delete and add snippets for Sink class #1222

merged 3 commits into from
Sep 5, 2016

Conversation

mziccard
Copy link
Contributor

@mziccard mziccard commented Sep 1, 2016

This PR does the following:

  • Remove unnecessary SinkInfo parameter for Sink.update and Sink.updateAsync
  • Fix deleteSink to properly return false on NOT_FOUND
  • Add snippets to Sink's javadoc, SinkSnippets class and tests

@mziccard mziccard added docs api: logging Issues related to the Cloud Logging API. labels Sep 1, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 85.197% when pulling fbd8c49 on mziccard:sink-snippets into 7309be5 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

mziccard commented Sep 1, 2016

/cc @lesv

@lesv
Copy link
Contributor

lesv commented Sep 1, 2016

LGTM

@mziccard mziccard merged commit 3ea98b1 into googleapis:master Sep 5, 2016
@mziccard mziccard changed the title Fix Metric.update/delete and add snippets for Metric class Fix Sink.update/delete and add snippets for Sink class Sep 8, 2016
@mziccard mziccard mentioned this pull request Sep 8, 2016
Closed
github-actions bot pushed a commit that referenced this pull request Aug 24, 2022
@release-please
chore(main): release 2.3.6-SNAPSHOT (#1222)
195ead9 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mziccard @coveralls @lesv @googlebot