Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Guava as a dependency of the examples project #1262

Conversation

jcanizales
Copy link

We're using it in one of the sample snippets to initialize maps in a sane way (using ImmutableMap.of(...)).

@lesv @mziccard

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2016
@mziccard
Copy link
Contributor

I'd prefer not to show Guava classes in snippets (Guava is not standard java and not all users use it or know it, adding Guava classes in snippets might just be confusing for people not familiar with them).

Also I believe this change is not necessary, Guava should already be available as it's a dependency of google-cloud-core.

@mziccard mziccard closed this Sep 17, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f9f021d on jcanizales:add-guava-to-example-dependencies into * on GoogleCloudPlatform:master*.

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022
Source-Link: googleapis/synthtool@18d4e9b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f8374176dc59291f05dd3fec927a9da2cda687a9ef4de32e77f699a2be12ab45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants