Update values and keys to v1beta3 #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| com.google.datastore.v1beta3.Key.Builder keyPb = com.google.datastore.v1beta3.Key.newBuilder(); | ||
| com.google.datastore.v1beta3.PartitionId.Builder partitionIdPb = | ||
| com.google.datastore.v1beta3.PartitionId.newBuilder(); | ||
| if (!Strings.isNullOrEmpty(projectId)) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Ok, done with first pass. Please make any necessary changes (preferably in one github commit) and ping back. |
ajkannan
force-pushed
the
update-datastore
branch
3 times, most recently
from
701939d
to
ebe997a
Compare
| @@ -62,7 +63,7 @@ public NullValue build() { | |||
| } | |||
|
|
|||
| @Override | |||
| public Builder set(Void value) { | |||
| public Builder set(com.google.protobuf.NullValue value) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ajkannan
force-pushed
the
update-datastore
branch
3 times, most recently
from
7a51c15
to
aad75ea
Compare
|
Looks good. Feel free to merge it to update-datastore branch and keep working on it. |
…Time are fixed, along with other minor edits
ajkannan
force-pushed
the
update-datastore
branch
from
aad75ea
to
9f40a5f
Compare
ajkannan
added a commit
that referenced
this pull request
Sep 19, 2015
Update values and keys to v1beta3
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
) This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/0ba8d2f8-7f35-417b-8c9a-d829ca01eac0/targets Source-Link: googleapis/synthtool@5b48b07
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
) * chore: update dependencies for regapic * add more dependencies and trigger comment * update goldens * fix indentation * remove duplicate gax-httpjson dependency * remove duplicated dependencies Source-Link: googleapis/synthtool@fa54eb2 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/4d646a8e-ed5d-4464-beec-8e528709fd94/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5d11bd2
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…ator_java versions (#161) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: https://github.com/googleapis/googleapis-gen/commit/230a5588306aae18fe8f2a57f14d4039ad72c901 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…1575) (#161) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…cies to v3.0.3 (#161) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://github.com/googleapis/java-shared-dependencies) | `3.0.2` -> `3.0.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v3.0.3`](https://github.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#​303-httpsgithubcomgoogleapisjava-shared-dependenciescomparev302v303-2022-09-14) [Compare Source](https://github.com/googleapis/java-shared-dependencies/compare/v3.0.2...v3.0.3) ##### Dependencies - Google-cloud-core 2.8.12 ([#​799](https://github.com/googleapis/java-shared-dependencies/issues/799)) ([1b3db8d](https://github.com/googleapis/java-shared-dependencies/commit/1b3db8d1e17c49ebae79fc96164fa9058e1df6e3)) - Moving gson to first-party-dependencies ([#​800](https://github.com/googleapis/java-shared-dependencies/issues/800)) ([a41fcc1](https://github.com/googleapis/java-shared-dependencies/commit/a41fcc11d32e02e5af2837561792e3919f6d4b3f)) - Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#​797](https://github.com/googleapis/java-shared-dependencies/issues/797)) ([bc5fdc9](https://github.com/googleapis/java-shared-dependencies/commit/bc5fdc9b3af7973c28f063a9ac156fe2af562814)) - Update gax.version to v2.19.1 ([#​798](https://github.com/googleapis/java-shared-dependencies/issues/798)) ([84e5487](https://github.com/googleapis/java-shared-dependencies/commit/84e5487b2e3dce4bb60badecebde788c3cb702b8)) - Update google.core.version to v2.8.11 ([#​793](https://github.com/googleapis/java-shared-dependencies/issues/793)) ([63c1297](https://github.com/googleapis/java-shared-dependencies/commit/63c129722aa0b821031ff5b4c11004adf7b12044)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-deploy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NS41In0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ## [1.1.6](googleapis/java-deploy@v1.1.5...v1.1.6) (2022-09-15) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#161](googleapis/java-deploy#161)) ([d2dae20](googleapis/java-deploy@d2dae20)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.3](googleapis/java-vmmigration@v1.3.2...v1.3.3) (2022-09-29) ### Dependencies * Update dependency cachetools to v5 ([#162](googleapis/java-vmmigration#162)) ([673c232](googleapis/java-vmmigration@673c232)) * Update dependency certifi to v2022.9.24 ([#142](googleapis/java-vmmigration#142)) ([40be099](googleapis/java-vmmigration@40be099)) * Update dependency charset-normalizer to v2.1.1 ([#146](googleapis/java-vmmigration#146)) ([c82b8bd](googleapis/java-vmmigration@c82b8bd)) * Update dependency click to v8.1.3 ([#147](googleapis/java-vmmigration#147)) ([99e10f7](googleapis/java-vmmigration@99e10f7)) * Update dependency gcp-releasetool to v1.8.8 ([#143](googleapis/java-vmmigration#143)) ([778f845](googleapis/java-vmmigration@778f845)) * Update dependency google-api-core to v2.10.1 ([#148](googleapis/java-vmmigration#148)) ([7b74afa](googleapis/java-vmmigration@7b74afa)) * Update dependency google-auth to v2.12.0 ([#149](googleapis/java-vmmigration#149)) ([6585870](googleapis/java-vmmigration@6585870)) * Update dependency google-cloud-core to v2.3.2 ([#144](googleapis/java-vmmigration#144)) ([cb815f8](googleapis/java-vmmigration@cb815f8)) * Update dependency google-cloud-storage to v2.5.0 ([#150](googleapis/java-vmmigration#150)) ([89e854a](googleapis/java-vmmigration@89e854a)) * Update dependency google-crc32c to v1.5.0 ([#151](googleapis/java-vmmigration#151)) ([dc88700](googleapis/java-vmmigration@dc88700)) * Update dependency googleapis-common-protos to v1.56.4 ([#145](googleapis/java-vmmigration#145)) ([5c8312d](googleapis/java-vmmigration@5c8312d)) * Update dependency importlib-metadata to v4.12.0 ([#152](googleapis/java-vmmigration#152)) ([c4ffddc](googleapis/java-vmmigration@c4ffddc)) * Update dependency jeepney to v0.8.0 ([#153](googleapis/java-vmmigration#153)) ([d84c437](googleapis/java-vmmigration@d84c437)) * Update dependency jinja2 to v3.1.2 ([#154](googleapis/java-vmmigration#154)) ([6682d82](googleapis/java-vmmigration@6682d82)) * Update dependency keyring to v23.9.3 ([#155](googleapis/java-vmmigration#155)) ([3d1a2d6](googleapis/java-vmmigration@3d1a2d6)) * Update dependency markupsafe to v2.1.1 ([#156](googleapis/java-vmmigration#156)) ([5666a1e](googleapis/java-vmmigration@5666a1e)) * Update dependency protobuf to v3.20.2 ([#157](googleapis/java-vmmigration#157)) ([e422694](googleapis/java-vmmigration@e422694)) * Update dependency protobuf to v4 ([#163](googleapis/java-vmmigration#163)) ([39884b8](googleapis/java-vmmigration@39884b8)) * Update dependency pyjwt to v2.5.0 ([#158](googleapis/java-vmmigration#158)) ([af206d0](googleapis/java-vmmigration@af206d0)) * Update dependency requests to v2.28.1 ([#159](googleapis/java-vmmigration#159)) ([83eb4d1](googleapis/java-vmmigration@83eb4d1)) * Update dependency typing-extensions to v4.3.0 ([#160](googleapis/java-vmmigration#160)) ([9d2cf45](googleapis/java-vmmigration@9d2cf45)) * Update dependency zipp to v3.8.1 ([#161](googleapis/java-vmmigration#161)) ([1ad1a9c](googleapis/java-vmmigration@1ad1a9c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Value and Key-related classes to use datastore v1beta3. As part of this change,
indexedis changed toexcludeFromIndexesandListValue's underlying representation is changed toArrayValue