Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the schema of dry run query jobs. #3159

Merged
merged 1 commit into from
Apr 17, 2018
Merged

Expose the schema of dry run query jobs. #3159

merged 1 commit into from
Apr 17, 2018

Conversation

mikekap
Copy link

@mikekap mikekap commented Apr 16, 2018

This can be very useful for running transitive type checks.

@mikekap mikekap requested a review from pongad as a code owner April 16, 2018 04:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 16, 2018
pongad
pongad reviewed Apr 16, 2018
View reviewed changes
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tswast

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/JobStatistics.java

/**
* Returns the schema for the query result. Present only for successful dry run of
* non-legacy SQL queries.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

pongad
pongad reviewed Apr 16, 2018
View reviewed changes
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (again) but @tswast should sign off

@pongad pongad merged commit 167ef27 into googleapis:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pongad pongad pongad left review comments

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikekap @tswast @pongad @googlebot