Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteGcsHelper #339

mziccard · 2015-11-09T16:17:49Z

This fixes #335

gcloud-java-storage/src/main/java/com/google/gcloud/storage/testing/RemoteGcsHelper.java

-   *     variables {@code GCLOUD_TESTS_PROJECT_ID} and {@code GCLOUD_TESTS_KEY} are not set or if
-   *     the file pointed by {@code GCLOUD_TESTS_KEY} does not exist
+   *     variables {@code GCLOUD_PROJECT} and {@code GOOGLE_APPLICATION_CREDENTIALS} are not set or
+   *     if the file pointed by {@code GOOGLE_APPLICATION_CREDENTIALS} does not exist
   */
  public static RemoteGcsHelper create() throws GcsHelperException {


mziccard · 2015-11-10T17:57:00Z

I fixed the comment and now RemoteGcsHelper uses default auth credentials.
This should not be merged until we fix default auth credentials NPE.

ajkannan · 2015-11-10T18:13:23Z

#344 is now merged in, which fixes the default auth credentials NPE

mziccard · 2015-11-10T18:39:46Z

I realized now that using default authentication credentials causes signUrl method to fail (see here) and consequently also signUrl IT tests fail.

We can manually pass a ServiceAccountAuthCredentials to signUrl but that is the same as explicitly creating ServiceAccountAuthCredentials from the env variables in RemoteGcsHelper.

I suggest that we do not use default lookup in RemoteGcsHelper unless you know a way to workaround the signUrl problem

gcloud-java-storage/src/main/java/com/google/gcloud/storage/testing/RemoteGcsHelper.java

@@ -45,8 +45,8 @@

  private static final Logger log = Logger.getLogger(RemoteGcsHelper.class.getName());
  private static final String BUCKET_NAME_PREFIX = "gcloud-test-bucket-temp-";
-  private static final String PROJECT_ID_ENV_VAR = "GCLOUD_TESTS_PROJECT_ID";
-  private static final String PRIVATE_KEY_ENV_VAR = "GCLOUD_TESTS_KEY";
+  private static final String PROJECT_ID_ENV_VAR = "GCLOUD_PROJECT";


aozarov · 2015-11-10T21:11:45Z

I realized now that using default authentication credentials causes signUrl method to fail (see here) and consequently also signUrl IT tests fail.

We could also support it when GoogleCredentials is instanceof ServiceAccountCredentials. There are various ways we could deal with it.

…csHelper

- Add a method to convert ApplicationDefaultCredentials to ServiceAccountAuthCredentials - Add type check and conversion to Storage.signUrl

mziccard · 2015-11-17T16:28:01Z

In 82ebc71 I fixed the comment and:

Added a method to convert ApplicationDefaultCredentials to ServiceAccountAuthCredentials if GoogleCredentials object is an instance of ServiceAccountCredentials
Add type check and conversion to Storage.signUrl to work with ApplicationDefaultCredentials

aozarov · 2015-11-17T17:30:07Z

Great! Looks good to me. Any reason you still have the "don't merge" label?

mziccard · 2015-11-17T18:05:00Z

I just forgot to remove :)

Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteGcsHelper

…manager to v0.118.6-alpha (googleapis#339) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:google-cloud-resourcemanager](https://github.com/GoogleCloudPlatform/google-cloud-java) | patch | `0.118.5-alpha` -> `0.118.6-alpha` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).

🤖 I have created a release *beep* *boop* --- ## [2.3.2](googleapis/java-workflow-executions@v2.3.1...v2.3.2) (2022-08-11) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#336](googleapis/java-workflow-executions#336)) ([eab4139](googleapis/java-workflow-executions@eab4139)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…ator_java versions (#339) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 472750037 Source-Link: googleapis/googleapis@88f2ea3 Source-Link: googleapis/googleapis-gen@230a558 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

mziccard added auth api: storage Issues related to the Cloud Storage API. testing labels Nov 9, 2015

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 9, 2015

aozarov reviewed Nov 9, 2015
View reviewed changes

mziccard force-pushed the integration-test-env-vars branch from e90f19a to cfdd6d6 Compare November 10, 2015 17:51

mziccard added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 10, 2015

aozarov reviewed Nov 10, 2015
View reviewed changes

mziccard force-pushed the integration-test-env-vars branch from cfdd6d6 to 9e273b4 Compare November 17, 2015 16:18

mziccard added 2 commits November 17, 2015 17:21

Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteG…

c3b6616

…csHelper

Add support for signUrl when default credentials are used

82ebc71

- Add a method to convert ApplicationDefaultCredentials to ServiceAccountAuthCredentials - Add type check and conversion to Storage.signUrl

mziccard force-pushed the integration-test-env-vars branch from 9e273b4 to 82ebc71 Compare November 17, 2015 16:23

mziccard removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 17, 2015

aozarov added a commit that referenced this pull request Nov 17, 2015

Merge pull request #339 from mziccard/integration-test-env-vars

4ecd840

Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteGcsHelper

aozarov merged commit 4ecd840 into googleapis:master Nov 17, 2015

github-actions bot pushed a commit that referenced this pull request Jul 1, 2022

chore: remove readme autosynth config (#339)

4280be1

This was referenced Aug 24, 2022

chore: release monorepo_script_output #8199

Closed

chore: release main #8222

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteGcsHelper #339

Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteGcsHelper #339

mziccard commented Nov 9, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Nov 10, 2015

ajkannan commented Nov 10, 2015

mziccard commented Nov 10, 2015

This comment was marked as spam.

aozarov commented Nov 10, 2015

mziccard commented Nov 17, 2015

aozarov commented Nov 17, 2015

mziccard commented Nov 17, 2015

Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteGcsHelper #339

Use GOOGLE_APPLICATION_CREDENTIALS and GCLOUD_PROJECT vars in RemoteGcsHelper #339

Conversation

mziccard commented Nov 9, 2015

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

mziccard commented Nov 10, 2015

ajkannan commented Nov 10, 2015

mziccard commented Nov 10, 2015

This comment was marked as spam.

aozarov commented Nov 10, 2015

mziccard commented Nov 17, 2015

aozarov commented Nov 17, 2015

mziccard commented Nov 17, 2015