Run tests for PRs to branches other than master

[mziccard]

This should fix #420.
Notice that #420 will be fixed only when this is merged/rebased in all other branches.

[jgeewax]

Just out of curiosity, if someone submits a PR (that none of us review) that echo's our encrypted keys in plaintext, what's the point of encrypting the keys ?

Should we have to approve it before the tests are run by OUR Travis instance?

[ajkannan]

@jgeewax Right now, we only decrypt the keys in non-PR Travis builds (see here), so I don't think that particular scenario can happen right now. If we happen to change the CI build code, we should be sure to decrypt the keys only when merging in a PR.

@mziccard Do you think we should remove the check for whether the branch is the master branch here.

[jgeewax]

Cool - so long as we're not opening up a gaping security hole :)

[mziccard]

@jgeewax Everything that we encrypt/decrypt needs travis encryption variables that are only available for non-PR builds (AFAIK). So decrypting the keys in a PR should not be possible.

@ajkannan I thought to leave integration tests only for master but you are right we should run them (if any) also in other branches. I'll fix this!

[aozarov]

Yes @mziccard is right. see this.