Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Cloud Bigtable Mutation fromProto #4461

Merged
merged 6 commits into from
Feb 8, 2019
Merged

Adding Cloud Bigtable Mutation fromProto #4461

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb459f4
Adding Cloud Bigtable Mutation fromProto
sduskis Feb 7, 2019
6b7b9ef
Fixing formatting
sduskis Feb 7, 2019
639c313
Merge branch 'master' into mutation_from_proto
sduskis Feb 7, 2019
8ab3baa
Addressing comments
sduskis Feb 7, 2019
7254346
Fixing lint issues.
sduskis Feb 7, 2019
8951d3b
adding a warning to `fromProtoUnsafe`
sduskis Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...oogle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/Mutation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,15 @@ public static Mutation createUnsafe() {
return new Mutation(true);
}


/** Wraps the List of protobuf {@link com.google.bigtable.v2.Mutation}. */
Copy link

@igorbernstein2 igorbernstein2 Feb 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a warning similar to createUnsafe:

It is the callers responsibility to make sure that all of the mutations have a deterministric timestamp. If a mutation has a serverside timestamp, then the mutation will no longer be idempotent, which might cause duplicate values to be stored in Bigtable. This option should only be used for advanced usecases with extreme care.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igorbernstein2: done.

@BetaApi
public static Mutation fromProtoUnsafe(List<com.google.bigtable.v2.Mutation> protos) {
Mutation mutation = new Mutation(true);
mutation.mutations.addAll(protos);
return mutation;
}

private Mutation(boolean allowServersideTimestamp) {
this.allowServersideTimestamp = allowServersideTimestamp;
}
Expand Down
2 changes: 2 additions & 0 deletions ...e-cloud-bigtable/src/test/java/com/google/cloud/bigtable/data/v2/models/MutationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ public void setCellTest() {
assertThat(actual.get(3).getSetCell().getValue())
.isEqualTo(ByteString.copyFromUtf8("fake-value2"));
assertThat(actual.get(3).getSetCell().getTimestampMicros()).isIn(expectedTimestampRange);

assertThat(Mutation.fromProtoUnsafe(actual).getMutations()).isEqualTo(actual);
}

@Test
Expand Down