Refactor BigQueryRpc and DefaultBigQueryRpc #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove options parameter where not necessary (query, cancel) - Unset JobInfo.type in create method as type is output only - Add javadoc to cancel method - Make checkstyle happy
googlebot
added
the
cla: yes
aozarov
added a commit
that referenced
this pull request
Dec 14, 2015
Refactor BigQueryRpc and DefaultBigQueryRpc
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-04-19 14:46:36,664 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-resourcemanager/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-04-19 14:46:37,958 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/9a701fb1-d89d-4626-be50-3c54e70783d5/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
…cies to v2.11.0 (#453) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://github.com/googleapis/java-shared-dependencies) | `2.10.0` -> `2.11.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v2.11.0`](https://github.com/googleapis/java-shared-dependencies/blob/HEAD/CHANGELOG.md#​2110-httpsgithubcomgoogleapisjava-shared-dependenciescomparev2100v2110-2022-05-18) [Compare Source](https://github.com/googleapis/java-shared-dependencies/compare/v2.10.0...v2.11.0) ##### Features - next release from main branch is 2.11.0 ([#​674](https://github.com/googleapis/java-shared-dependencies/issues/674)) ([611e3b7](https://github.com/googleapis/java-shared-dependencies/commit/611e3b7c50108a71efc94415166b85d2bf8647e5)) ##### Dependencies - update dependency com.fasterxml.jackson:jackson-bom to v2.13.3 ([#​689](https://github.com/googleapis/java-shared-dependencies/issues/689)) ([03897e3](https://github.com/googleapis/java-shared-dependencies/commit/03897e30a71f8f1aa37233da2433ee5afccc1d61)) - update dependency com.google.api-client:google-api-client-bom to v1.34.1 ([#​685](https://github.com/googleapis/java-shared-dependencies/issues/685)) ([9bc0557](https://github.com/googleapis/java-shared-dependencies/commit/9bc0557d8ce2f3d8dc7c8ffafdd36fd4c03e2df5)) - update dependency com.google.api:api-common to v2.2.0 ([#​690](https://github.com/googleapis/java-shared-dependencies/issues/690)) ([47a8736](https://github.com/googleapis/java-shared-dependencies/commit/47a87365e51f73132b15b054d85f8c9baa8e89f6)) - update dependency com.google.auth:google-auth-library-bom to v1.7.0 ([#​691](https://github.com/googleapis/java-shared-dependencies/issues/691)) ([ec6aab7](https://github.com/googleapis/java-shared-dependencies/commit/ec6aab72eaed43574efe47a696bba6a612f161bb)) - update dependency com.google.errorprone:error_prone_annotations to v2.13.1 ([#​672](https://github.com/googleapis/java-shared-dependencies/issues/672)) ([8c7e530](https://github.com/googleapis/java-shared-dependencies/commit/8c7e530d3c7170b2fb76cc27a05164524ba4e00b)) - update dependency com.google.http-client:google-http-client-bom to v1.41.8 ([#​684](https://github.com/googleapis/java-shared-dependencies/issues/684)) ([1305356](https://github.com/googleapis/java-shared-dependencies/commit/1305356775247dbb641b60654ac56da43513088e)) - update dependency com.google.protobuf:protobuf-bom to v3.20.1 ([#​678](https://github.com/googleapis/java-shared-dependencies/issues/678)) ([3e6d4a1](https://github.com/googleapis/java-shared-dependencies/commit/3e6d4a1a8e5d45723071a62c99bb1ab87d2b2b84)) - update dependency io.grpc:grpc-bom to v1.46.0 ([#​680](https://github.com/googleapis/java-shared-dependencies/issues/680)) ([b8a052b](https://github.com/googleapis/java-shared-dependencies/commit/b8a052b75a1bc2703500b4f31c5c6dac887ab8be)) - update dependency org.checkerframework:checker-qual to v3.22.0 ([#​683](https://github.com/googleapis/java-shared-dependencies/issues/683)) ([b0a30cd](https://github.com/googleapis/java-shared-dependencies/commit/b0a30cdecae8dcfb3a6d36e3f194c39a0086673e)) - update gax.version to v2.17.0 ([#​687](https://github.com/googleapis/java-shared-dependencies/issues/687)) ([e0e89ea](https://github.com/googleapis/java-shared-dependencies/commit/e0e89eade481effc723c9c7261f2ebf4e5883621)) - update gax.version to v2.18.0 ([#​692](https://github.com/googleapis/java-shared-dependencies/issues/692)) ([9536612](https://github.com/googleapis/java-shared-dependencies/commit/9536612c77af1e4d912c5b63515ea6f750e53810)) - update google.core.version to v2.6.1 ([#​671](https://github.com/googleapis/java-shared-dependencies/issues/671)) ([e3d1aeb](https://github.com/googleapis/java-shared-dependencies/commit/e3d1aebed31f8e91109d5865afd9525ac3595c90)) - update google.core.version to v2.7.0 ([#​693](https://github.com/googleapis/java-shared-dependencies/issues/693)) ([2171677](https://github.com/googleapis/java-shared-dependencies/commit/2171677e16190de9f37dc16c924d829ea8ccd86c)) - update iam.version to v1.3.2 ([#​673](https://github.com/googleapis/java-shared-dependencies/issues/673)) ([9882baa](https://github.com/googleapis/java-shared-dependencies/commit/9882baa3ecc8d7584788af1916f0d8c5ec670b5c)) - update iam.version to v1.3.3 ([#​679](https://github.com/googleapis/java-shared-dependencies/issues/679)) ([9fe34c8](https://github.com/googleapis/java-shared-dependencies/commit/9fe34c89eabed5eeebad986bffeeeb64dbbc38c1)) - update iam.version to v1.3.4 ([#​686](https://github.com/googleapis/java-shared-dependencies/issues/686)) ([4e95b3a](https://github.com/googleapis/java-shared-dependencies/commit/4e95b3a1d4302812338c220df316391c19ef7473)) - update opencensus.version to v0.31.1 ([#​682](https://github.com/googleapis/java-shared-dependencies/issues/682)) ([5d25746](https://github.com/googleapis/java-shared-dependencies/commit/5d25746bc6c9329b240204cbe7b83e2fee4c6cb3)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-workflows).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [2.2.0](googleapis/java-workflows@v2.1.10...v2.2.0) (2022-05-24) ### Features * add build scripts for native image testing in Java 17 ([#1440](https://github.com/googleapis/java-workflows/issues/1440)) ([#454](googleapis/java-workflows#454)) ([7eacda8](googleapis/java-workflows@7eacda8)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#453](googleapis/java-workflows#453)) ([bc891e9](googleapis/java-workflows@bc891e9)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#455](googleapis/java-workflows#455)) ([7a47d41](googleapis/java-workflows@7a47d41)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
](https://renovatebot.com){kind=link}
- [ ] Regenerate this pull request now. Committer: @Guisin PiperOrigin-RevId: 458302463 Source-Link: googleapis/googleapis@523fdaf Source-Link: https://github.com/googleapis/googleapis-gen/commit/b3f1325af8bdfc19d92d34eec02e06cdbed14479 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjNmMTMyNWFmOGJkZmMxOWQ5MmQzNGVlYzAyZTA2Y2RiZWQxNDQ3OSJ9
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jul 1, 2022
🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/java-assured-workloads@v1.1.0...v2.0.0) (2022-07-01) ### ⚠ BREAKING CHANGES * proto file name is changed from assuredworkloads_v1beta1.proto to assuredworkloads.proto ### Features * Enable REST transport for most of Java and Go clients ([googleapis#448](googleapis/java-assured-workloads#448)) ([2ec7bb4](googleapis/java-assured-workloads@2ec7bb4)) * ITAR June Preview Launch ([googleapis#453](googleapis/java-assured-workloads#453)) ([eeed2fd](googleapis/java-assured-workloads@eeed2fd)) * Removed _v1beta1 suffix from proto file names ([googleapis#443](googleapis/java-assured-workloads#443)) ([853eb5b](googleapis/java-assured-workloads@853eb5b)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#450](googleapis/java-assured-workloads#450)) ([c115d5f](googleapis/java-assured-workloads@c115d5f)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#447](googleapis/java-assured-workloads#447)) ([3b07e54](googleapis/java-assured-workloads@3b07e54)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
…s to v2.4.3 (#453) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-functions](https://github.com/googleapis/java-functions) | `2.4.1` -> `2.4.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-functions</summary> ### [`v2.4.3`](https://github.com/googleapis/java-functions/blob/HEAD/CHANGELOG.md#​243-httpsgithubcomgoogleapisjava-functionscomparev242v243-2022-07-13) [Compare Source](https://github.com/googleapis/java-functions/compare/v2.4.2...v2.4.3) ##### Bug Fixes - enable longpaths support for windows test ([#​1485](https://github.com/googleapis/java-functions/issues/1485)) ([#​443](https://github.com/googleapis/java-functions/issues/443)) ([7687177](https://github.com/googleapis/java-functions/commit/7687177d2f0ca0f56ec34c02006124b014541699)) ### [`v2.4.2`](https://github.com/googleapis/java-functions/blob/HEAD/CHANGELOG.md#​242-httpsgithubcomgoogleapisjava-functionscomparev241v242-2022-07-01) [Compare Source](https://github.com/googleapis/java-functions/compare/v2.4.1...v2.4.2) ##### Bug Fixes - update gapic-generator-java with mock service generation fixes ([#​424](https://github.com/googleapis/java-functions/issues/424)) ([898dfd9](https://github.com/googleapis/java-functions/commit/898dfd98c0a7d877ea8f9256bd84f82ae375746b)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-functions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…1.1 (#453) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://github.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-security-private-ca). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE4NC4yIn0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
…1575) (#453) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues with
BigQueryRpcandDefaultBigQueryRpc, mainly:query,cancel)JobInfo.typeincreatemethod as type is output only