Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spanner now extends AutoCloseable #4687

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Spanner now extends AutoCloseable #4687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...le-cloud-clients/google-cloud-spanner/src/main/java/com/google/cloud/spanner/Spanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
* longer needed. Failure to do so may result in leaking session resources and exhausting session
* quota.
*/
public interface Spanner extends Service<SpannerOptions> {
public interface Spanner extends Service<SpannerOptions>, AutoCloseable {
/** Returns a {@code DatabaseAdminClient} to do admin operations on Cloud Spanner databases. */
/*
* <!--SNIPPET get_dbadmin_client-->
Expand Down Expand Up @@ -103,5 +103,6 @@ public interface Spanner extends Service<SpannerOptions> {
* a hard limit on number of sessions in Cloud Spanner and not calling this method can lead to
* unused sessions piling up on the backend.
*/
@Override
void close();
}