Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Storage: Fix manage resumeable signedURL uploads. #4871

Closed

Conversation

abhinav-qlogic
Copy link

Fixes #2462

@abhinav-qlogic abhinav-qlogic requested a review from a team as a code owner April 2, 2019 12:28
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2019
@pmakani pmakani added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2019
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #4871 into master will decrease coverage by 0.63%.
The diff coverage is 23.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4871      +/-   ##
============================================
- Coverage     50.06%   49.42%   -0.64%     
+ Complexity    22831    21521    -1310     
============================================
  Files          2174     2174              
  Lines        217633   213197    -4436     
  Branches      24267    23414     -853     
============================================
- Hits         108954   105369    -3585     
+ Misses       100335    99614     -721     
+ Partials       8344     8214     -130
Impacted Files Coverage Δ Complexity Δ
...va/com/google/cloud/storage/spi/v1/StorageRpc.java 62.85% <ø> (ø) 0 <0> (ø) ⬇️
...rc/main/java/com/google/cloud/storage/Storage.java 85.88% <ø> (ø) 0 <0> (ø) ⬇️
...om/google/cloud/storage/spi/v1/HttpStorageRpc.java 1.82% <0%> (-0.06%) 1 <0> (ø)
...ud/storage/contrib/nio/testing/FakeStorageRpc.java 63.54% <0%> (-0.32%) 40 <0> (ø)
...ain/java/com/google/cloud/storage/StorageImpl.java 85.54% <0%> (-0.35%) 95 <0> (ø)
...ava/com/google/cloud/storage/BlobWriteChannel.java 88.88% <81.81%> (-2.29%) 8 <3> (+3)
.../java/com/google/cloud/testing/CommandWrapper.java 90.9% <0%> (-6.07%) 13% <0%> (ø)
...in/java/com/google/cloud/storage/StorageBatch.java 88% <0%> (-4%) 13% <0%> (ø)
...e/cloud/vision/v1p4beta1/ImageAnnotatorClient.java 58.69% <0%> (-3.31%) 15% <0%> (-4%)
...e/cloud/vision/v1p3beta1/ImageAnnotatorClient.java 47.05% <0%> (-2.95%) 9% <0%> (-2%)
... and 531 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9923d57...5f78509. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storage service should manage resumeable signedURL uploads
4 participants