Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulating a notion of "message batch" in pub/sub #4951

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Encapsulating a notion of "message batch" in pub/sub #4951

merged 3 commits into from
Apr 16, 2019

Conversation

sduskis
Copy link
Contributor

@sduskis sduskis commented Apr 15, 2019

This is inspired by the changes in the ordering keys branch.

@kimkyung-goog, FYI

@sduskis
Encapsulating a notion of "message batch" in pub/sub
cf37ad1 
This is inspired by the changes in the ordering keys branch.
@sduskis sduskis requested a review from a team as a code owner April 15, 2019 15:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2019
@codecov
Copy link

codecov bot commented Apr 15, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2fc4e55). Click here to learn what that means.
The diff coverage is 96.96%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4951   +/-   ##
=========================================
  Coverage          ?   50.05%           
  Complexity        ?    23699           
=========================================
  Files             ?     2233           
  Lines             ?   226002           
  Branches          ?    24228           
=========================================
  Hits              ?   113128           
  Misses            ?   103533           
  Partials          ?     9341
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 81.97% <96.96%> (ø) 45 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fc4e55...4da3c2e. Read the comment docs.

olavloite
olavloite approved these changes Apr 16, 2019
View reviewed changes
...le-cloud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Publisher.java Outdated
private int getMessagesCount() {
return messages.size();
}
};
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick: semicolon at the end of class definition is not required (and not common) in Java.
Otherwise, this looks good to me.

@sduskis sduskis merged commit b1ebd2d into googleapis:master Apr 16, 2019
@kolea2 kolea2 mentioned this pull request Apr 17, 2019
Merged
@sduskis sduskis deleted the refactor_message_batch branch April 22, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sduskis @olavloite @googlebot